[ DateTime | RFC ] HH\Lib\Experimental\Time::zero() is neither positive or negative, add ->isPositiveOrZero()

[lexidor]

I believe this might be a language thing. I do not know if this is confusing to others. This might be very be a European thing.

• In typical French mathematical usage, zero is both positive and negative. Or rather, in mathematical French "𝑥 est positif" (literally "𝑥 is positive") allows the case 𝑥=0, while "𝑥 est positif strictement" (literally "𝑥 is strictly positive") does not.
• In mathematical French, it just happens that the word 'positif' is defined to be ≥0, that is, 0 is both 'positif' and 'negatif'.

The French have a concept of strictly positive and strictly negative, which match the common English definition, which excludes zero. Interesting to note, the docblock of the class itself does not acknowledge zero, since May be positive or negative seems to suggest that zero is not an option.

/**
 * Represents a time interval (a specific number of hours, minutes, seconds, and
 * nanoseconds). May be positive or negative. All instances are immutable.

May I suggest adding ->isPositiveOrZero() and ->isNegativeOrZero(). Not because ->isPositive() || ->isZero() or !->isNegative() is to hard to write, but as a reminder to programmers who navigate autocomplete to think about what to do with zero. This small reminder might make a large difference.

$z = Time::zero();
// Already exist
$z->isPositive(); // false
$z->isNegative(); // false
// New functions
$z->isPositiveOrZero(); // true
$z->isNegativeOrZero(); // true