Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Add safety checks to promote-nightly-to-release.sh #187

Open
1 of 3 tasks
fredemmott opened this issue Jul 22, 2019 · 1 comment
Open
1 of 3 tasks

Add safety checks to promote-nightly-to-release.sh #187

fredemmott opened this issue Jul 22, 2019 · 1 comment

Comments

@fredemmott
Copy link
Contributor

fredemmott commented Jul 22, 2019

  • make sure date is recent (e.g. last 7 days)
  • compare to current hhvm tags - if 4.x is requested, make sure that 4.x.0 does not already exist, and that 4.(x-1).0 does
  • make sure that we have gnu sed available (SED="$(if [ "$(uname -s)" == "Darwin" ]; then echo gsed; else echo sed; fi)" then checking that $SED is executable)

This could hard-fail (and be commented out to override) or prompt for confirmation (not for sed failure though)

fredemmott added a commit to fredemmott/hhvm-packaging that referenced this issue Jul 22, 2019
fredemmott added a commit that referenced this issue Jul 23, 2019
@fredemmott
Copy link
Contributor Author

Also #207 to check remote

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant