Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement git clone, commit, and push, and overwrite directives #5

Closed
wants to merge 25 commits into from
Closed

feat: implement git clone, commit, and push, and overwrite directives #5

wants to merge 25 commits into from

Conversation

krancour
Copy link

@krancour krancour commented Aug 28, 2024 •
edited
Loading

WIP

@hiddeco hiddeco force-pushed the promotion-directives branch from e3c3941 to 367ad99 Compare August 29, 2024 19:45
@krancour krancour force-pushed the krancour/git-promo-dirs-pt-2 branch 3 times, most recently from ddbffe2 to 47cc53c Compare September 3, 2024 18:52
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 21.03659% with 259 lines in your changes missing coverage. Please review.

Please upload report for BASE (promotion-directives@6c63610). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/directives/git_clone_directive.go 4.38% 109 Missing ⚠️
internal/directives/git_push_directive.go 10.71% 50 Missing ⚠️
internal/directives/git_overwrite_directive.go 18.18% 45 Missing ⚠️
internal/directives/git_commit_directive.go 16.12% 26 Missing ⚠️
internal/controller/git/base_repo.go 63.15% 6 Missing and 1 partial ⚠️
internal/controller/git/bare_repo.go 33.33% 2 Missing and 4 partials ⚠️
internal/controller/git/work_tree.go 0.00% 6 Missing ⚠️
internal/directives/copy_directive.go 0.00% 4 Missing ⚠️
internal/directives/engine.go 75.00% 2 Missing and 1 partial ⚠️
internal/directives/directive.go 50.00% 1 Missing and 1 partial ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@                   Coverage Diff                   @@
##             promotion-directives       #5   +/-   ##
=======================================================
  Coverage                        ?   48.35%           
=======================================================
  Files                           ?      260           
  Lines                           ?    18380           
  Branches                        ?        0           
=======================================================
  Hits                            ?     8887           
  Misses                          ?     9001           
  Partials                        ?      492

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco force-pushed the promotion-directives branch 2 times, most recently from 483e68e to 3eff6c4 Compare September 3, 2024 20:33
hiddeco and others added 7 commits September 3, 2024 22:40
@hiddeco
feat: Promotion Directives engine outline
971e33b 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
feat: outline directive implementation example
7a146bb 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
chore: slightly reorganize namings
eec6c77 
Signed-off-by: Hidde Beydals <[email protected]>
@krancour @hiddeco
initial scaffolding for directive validation and git-based directives
8ee9443 
Signed-off-by: Kent Rancourt <[email protected]>
@krancour @hiddeco
fix minor lint issues
0ded23b 
Signed-off-by: Kent Rancourt <[email protected]>
@krancour @hiddeco
update directive registration and execution engine to manage special …
72894a0 
…privileges

Signed-off-by: Kent Rancourt <[email protected]>
@krancour @hiddeco
fix directive execution engine bug that was creating a file instead o…
6c63610 
…f a dir

Signed-off-by: Kent Rancourt <[email protected]>
@hiddeco hiddeco force-pushed the promotion-directives branch from 3eff6c4 to 6c63610 Compare September 3, 2024 20:42
@krancour krancour force-pushed the krancour/git-promo-dirs-pt-2 branch from f8ad9b4 to 25cb17e Compare September 3, 2024 21:58
@krancour krancour changed the title feat: implement git clone directive feat: implement git clone, commit, and push directives Sep 3, 2024
@krancour krancour force-pushed the krancour/git-promo-dirs-pt-2 branch from 25cb17e to 7923f30 Compare September 3, 2024 22:00
@krancour krancour mentioned this pull request Sep 3, 2024
Merged
@krancour krancour force-pushed the krancour/git-promo-dirs-pt-2 branch 2 times, most recently from e15bbb7 to 8b60713 Compare September 7, 2024 07:50
@krancour krancour changed the title feat: implement git clone, commit, and push directives feat: implement git clone, commit, and push, and overwrite directives Sep 7, 2024
@krancour krancour force-pushed the krancour/git-promo-dirs-pt-2 branch from 8b60713 to df72d6c Compare September 7, 2024 07:51
@hiddeco
feat: implement copy directive
0fde91b 
Signed-off-by: Hidde Beydals <[email protected]>
@krancour krancour force-pushed the krancour/git-promo-dirs-pt-2 branch 3 times, most recently from e3ceeb6 to b433eed Compare September 10, 2024 05:23
krancour and others added 2 commits September 10, 2024 18:15
@krancour @hiddeco
feat: add Output to directive Result
41d4256 
Signed-off-by: Kent Rancourt <[email protected]>
@hiddeco
chore: allow precise control over returned Result
3430879 
With an eye on more status types getting introduced later. It is of
importance to maintain control over what `Result` is being returned,
instead of marking everything as a `Failure` on any error.

Signed-off-by: Hidde Beydals <[email protected]>
@krancour krancour force-pushed the krancour/git-promo-dirs-pt-2 branch from b433eed to 003c461 Compare September 10, 2024 18:06
@hiddeco
chore: prepare Freight utils to work without Stage
867e026 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
feat: introduce helm-update-chart directive
6926ee0 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
feat: add helm-update-image directive
261be5b 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
feat: add helm-template directive
9bb84e3 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
chore: improve and add helm-update-chart tests
0f2161a 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
chore: improve helm-update-image code and tests
8a56df3 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
chore: avoid returning duplicate error string
47b0735 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
chore: tweak directive constructors
d970092 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
chore: incorporate Result changes
00e5a3d 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
feat: provide commit msg output for helm-update-image
95f0595 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
feat: provide commit msg output for helm-chart-update
cd68fb6 
Signed-off-by: Hidde Beydals <[email protected]>
@krancour krancour force-pushed the krancour/git-promo-dirs-pt-2 branch 4 times, most recently from d80dd3c to 170f201 Compare September 11, 2024 18:24
@krancour
slight refactoring of freight finder
1898096 
Signed-off-by: Kent Rancourt <[email protected]>
@krancour
add git-based directives
23802aa 
Signed-off-by: Kent Rancourt <[email protected]>
@krancour
open pr wip
e68e625 
Signed-off-by: Kent Rancourt <[email protected]>
@krancour
more git pkg improvements
22d6d8c 
Signed-off-by: Kent Rancourt <[email protected]>
@krancour krancour force-pushed the krancour/git-promo-dirs-pt-2 branch from 99dd9ae to 22d6d8c Compare September 13, 2024 20:19
@hiddeco hiddeco force-pushed the promotion-directives branch from 9c90df1 to 41b3181 Compare September 16, 2024 15:12
@krancour
Copy link
Author

Superseded by akuity#2537

@krancour krancour closed this Sep 16, 2024
@krancour krancour deleted the krancour/git-promo-dirs-pt-2 branch September 27, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krancour @codecov-commenter @hiddeco