Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance in exporting #383

Closed
timfaase opened this issue Feb 9, 2023 · 4 comments
Closed

Performance in exporting #383

timfaase opened this issue Feb 9, 2023 · 4 comments

Comments

@timfaase
Copy link

timfaase commented Feb 9, 2023

We have done some tests with the latest build: https://github.com/highcharts/node-export-server/tree/enhancement/puppeteer.

In our initial tests the performance is insufficient for our goals. Average performance of exporting a chart is around 1 second. We tried running with more memory with no success.

We have an existing setup using JavaFX which takes about 300 ms for the same image.

Is there a way to boost performance?

@askdesigners
Copy link

There is not. This repo is basically abandoned, and the code quality is very poor. We sank a lot of time into trying to get this junk heap to work at all without falling over constantly with no success. We ended up using browserless for our rendering, which is also a giant pain.

I wish Highcharts was built in a way that would allow for rendering svgs without a browser, but sadly it is not.

@Waterstraal
Copy link

@jakubSzuminski Any update on this?

@jszuminski
Copy link
Contributor

jszuminski commented Oct 16, 2023

@timfaase we've recently merged a new PR (#422) where we replaced the generic-pool package with tarn which, at least in our tests, improved the performance.

Could you please try out the latest version (from the stable branch or from the npm [email protected]) and let us know whether it works faster? Do you encounter any issues with this?

@jszuminski
Copy link
Contributor

Fixed in v4.0.0 (current master) by #521.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants