Onboarding/Permissions: Button takes existing user to settings page to allow permissions

[mstidham]

Button takes existing user to settings page to allow permissions

QA TEMPLATE	Input
Device Type:	iPhone 7 Plus
iOS:	12.2
tr Version:	4.11.0
Environment	Staging
Codepush:
Internet Connection Type:	WiFi
Users affected?	Miranda
User handle:	@miranda
Bypass handle?:	@TestyTester (191-9191)
Location access type?	Always
Does this issue occur on other environments?
Time issue occurred (UTC)

Observed Result:

Existing users that have previously denied permissions see the missing onboarding screens but the ios popup doesn't appear for the 2nd time.

Expected Result:

User should be presented with onboarding screens for previously denied permissions. When user taps button take user to the settings page for that permission.

Steps to reproduce:

1. Upgrade app with denied permissions
2. User is presented with onboarding screens but tapping allow doesn't present ios popup so user is mislead thinking they have granted the permission.

Related Screenshots/Video Links:

---

Original Ticket #3358

[bengtan]

User should be presented with onboarding screens for previously denied permissions.

I dunno if this is possible or not, with iOS. Deferring to @aksonov or @southerneer.

[aksonov]

@mstidham what permissions are denied? Could you post video?

[bengtan]

@aksonov:

I think this ticket is a spin off from #3358 (comment):

I denied the permission on previous version (accelerometer and notifications) and then updated the app. I then only saw the onboarding screens for accelerometer and notifications but didn't receive the ios popups. My thought is if we don't provide the popups to change the setting why show the screens.

(but also read the next subsequent comments too)

... so I'm guessing she denied permissions for the accelerometer and notifications.

But I could be guessing wrong.

[mstidham]

I just created a video showing that if you deny permissions with one version and then update the app you get the denied onboarding screens but when the user taps Allow button it does not function. User should be taken to the settings screen to actually change the setting to Allow. Video is long see below.

https://app.box.com/s/zmx3z5a1njgak8a0bz5x8z5hv1owuexq

[southerneer]

I don't think @mstidham should expect to get taken to the settings page because we haven't made those changes yet. As I said in my comment on the referenced ticket we should codify those requirements in a new ticket rather than creating a bug ticket.

[mstidham]

@southerneer I don't know what codify those requirements in a new ticket is, so please close this ticket if it's not what was needed.

[southerneer]

Yeah, just trying to point out to @bengtan that this is new work (which may be lower priority than other tickets) vs a regression/bug.

[aksonov]

I can't reproduce it, @mstidham can you?

[mstidham]

@aksonov I can still reproduce this. I do not get the iOS popups to change the settings. I installed 4.37.0 and denied the permissions (motion/fitness & notifications). I then upgraded to 4.38.0 and saw the onboarding screens but selecting Allow doesn't change the settings.

[aksonov]

Oh, I thought permissions here is 'location permissions'. Now I understand.

[mstidham]

I think this will need to be tested once there is an additional deploy. I will need to have 4.39.0 installed with denied permissions and then upgrade.

[aksonov]

I didn’t work on this ticket yet, no need to test Sent from iPhone

…

On 13 Feb 2020, at 21:10, mstidham ***@***.***> wrote:  I think this will need to be tested once there is an additional deploy. I will need to have 4.39.0 installed with denied permissions and then upgrade. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[southerneer]

So I think we should do away with the constant onboarding altogether: https://github.com/hippware/collaboration/issues/22

Going through the list of onboarding screens and ways of replacing their functionality:

• Location: We already have a UI overlay if the user has disabled "always" location settings.
• Motion/accelerometer: I'm not sure how denying/disabling this permission would affect rnbgl (@bengtan ?). If we absolutely need it for the app to function correctly then we can do the same thing as the Location permission overlay. If not, then removing this constant onboarding flow would be good.
• Push notifications: If the user disables/denies notifications settings there might be a good reason for that. Continually showing the notifications permissions onboarding screen is probably bad.
• Contact permissions/list: since we now have another way to get to this list/permission outside of the onboarding flow I don't think we should show this slide more than once.

Thoughts @irfirl @thescurry ?

[southerneer]

We'll await more discussion (maybe on the Thursday call?) before pursuing this further.

[bengtan]

Motion/accelerometer: I'm not sure how denying/disabling this permission would affect rnbgl

The RNBGL docs say (at https://transistorsoft.github.io/react-native-background-geolocation/interfaces/_react_native_background_geolocation_.config.html#disablemotionactivityupdates):

The plugin is HIGHLY optimized for motion-activity-updates. If you do disable this, the plugin will drain more battery power. You are STRONGLY advised against disabling this.

Furthermore, if the Motion & Fitness permission has not been granted by the time location tracking starts, RNBGL will, by default, ask for it.

[southerneer]

Ah ok. So it probably makes sense to have an overlay similar to the Location permissions warning we currently use:

@irfirl if you agree could you please mock something up and post it here?

[irfirl]

Updated: https://zpl.io/2Eoo3wg

[bengtan]

(Sort of off-topic)

We'll await more discussion (maybe on the Thursday call?) before pursuing this further.

Spun out at #4850.

[southerneer]

#4850 and #4851 covers the 2 conclusions of the Thursday discussion so I'm closing this ticket.