Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Location onboarding to use more generic text instead of Always Allow #4871

Open
southerneer opened this issue Mar 5, 2020 · 12 comments
Assignees

Comments

@southerneer
Copy link
Contributor

southerneer commented Mar 5, 2020

Only choices are "when in use" and "once" (on ios 13)? I believe it's the same as this issue: zoontek/react-native-permissions#379

@southerneer southerneer self-assigned this Mar 5, 2020
@southerneer
Copy link
Contributor Author

@mstidham you may have run into this one already. If you already created a ticket could you please link it here?

@bengtan
Copy link
Contributor

bengtan commented Mar 5, 2020

IIRC, on iOS 13, for a newly installed app, the first (few?) time(s) the iOS location permission dialog comes up, it only allows the user to choose 'When in use' and 'Once'. It doesn't allow the selection of 'Always'.

After the app has been used/installed for a while (3 days? A few days?), then it allows the selection of 'Always' (which replaces 'Once').

But ... my memory is not perfect so please do your own testing/research. I may be wrong.

@bengtan
Copy link
Contributor

bengtan commented Mar 5, 2020

Previous ticket: [ios] Location services: "Always Allow" is not a pop-up option #4250

@aksonov
Copy link
Contributor

aksonov commented Mar 5, 2020

@bengtan Yes, it is by iOS 13 design, you are right. I didn't have problem with our app when I selected 'Once' for first run and then 'Always' later.

@aksonov
Copy link
Contributor

aksonov commented Mar 5, 2020

@southerneer And I believe I already investigated this issue and reported it to Miranda (that it is not in our code, it is because of iOS 13). Or you created this ticket after your testing?

@southerneer
Copy link
Contributor Author

southerneer commented Mar 5, 2020

I didn't have problem with our app when I selected 'Once' for first run and then 'Always' later.

That makes sense, perhaps I should reword the title. The problem isn't that the app is broken in any way after the ios 13 changes, it's that the wording on the Onboarding screen ("With 'Always Allow' you won’t miss out on relevant location notifications.") doesn't reflect the choices presented to the user when they press the "Always Allow Location" button. I think that should be addressed. cc @irfirl

Thanks for linking the earlier issue @bengtan and reporting @mstidham

@southerneer southerneer changed the title [ios] Onboarding doesn't ask for "always" permission [ios] after ios 13 "Always Allow" is no longer an initial location permission option Mar 5, 2020
@southerneer southerneer changed the title [ios] after ios 13 "Always Allow" is no longer an initial location permission option [ios] after ios 13 "Always Allow" is no longer an option for location permissions popup Mar 5, 2020
@irfirl
Copy link
Contributor

irfirl commented Mar 5, 2020

Updated the messaging on the mock: https://zpl.io/an4vN7A

@aksonov
Copy link
Contributor

aksonov commented Mar 12, 2020

I see issue now after I selected "Once" for ios popup. Hm, it is very unfriendly, I think we should allow 'Once' for first use.. @southerneer ?

Simulator Screen Shot - iPhone 8 Plus - 2020-03-12 at 17.45.56.png

@southerneer
Copy link
Contributor Author

southerneer commented Mar 12, 2020

Maybe so, but that's a whole new set of changes. If we allow "once" for first use but then show the location warning modal immediately for the next app run that's not very friendly either. I think that problem warrants more discussion.

@aksonov
Copy link
Contributor

aksonov commented Mar 12, 2020

I think we could request 'Always' next time and show this UI modal normally because iOS 13 will ask user with their popup at the same time (with 'Allow always' choice)

@southerneer
Copy link
Contributor Author

I think we could request 'Always' next time and show this UI modal normally because iOS 13 will ask user with their popup at the same time (with 'Allow always' choice)

This won't work because we can only explicitly request permissions once. Subsequent changes require sending the user to the settings screen. This article gives a decent overview of the iOS 13 changes and how the flow works in different use cases. I think @irfirl 's suggestion of going back to the generic "Allow Location Access" makes sense for now. If we want to get more specific for iOS 13 later we can address that in a new ticket.

@bengtan
Copy link
Contributor

bengtan commented Mar 18, 2020

QA notes:

Instead of emphasising 'Always Allow', the Onboarding Location screen/modal should now say:

Don’t miss out on relevant
location notifications by allowing
location access

followed by:

Allow Location Access

@bengtan bengtan changed the title [ios] after ios 13 "Always Allow" is no longer an option for location permissions popup [ios] Location onboarding to use more generic text instead of Always Allow Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants