Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Not Sharing Location" on card of users sharing nearby #4904

Open
mstidham opened this issue Mar 11, 2020 · 1 comment
Open

"Not Sharing Location" on card of users sharing nearby #4904

mstidham opened this issue Mar 11, 2020 · 1 comment

Comments

@mstidham
Copy link

mstidham commented Mar 11, 2020

User testiPhone (650)555-0002 shared live location "Nearby" to user Pixel. Both users have the app in the foreground. User Pixel shares live location back and selects "Nearby". Users see "Not Sharing Location" on the card. The iPhone eventually updates with no action (very long delay) but the android did not update and required a kill/reload to get the card to update. I feel like the card should display something like "Sharing Nearby" if the location data point is not available.

Snip20200311_38

@bengtan
Copy link
Contributor

bengtan commented Mar 12, 2020

How about this?

  • For user cards, if (a) there is no location data point, and (b) if the user is sharing Nearby, then: Instead of showing 'Not Sharing Location', it shows 'Not Nearby'.

and then we can re-evaluate this ticket ie. re-assess this sentence:

The iPhone eventually updates with no action (very long delay) but the android did not update and required a kill/reload to get the card to update.

southerneer pushed a commit that referenced this issue Mar 16, 2020
aksonov added a commit that referenced this issue Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants