Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'jdbc_additional_params' attribute not created in Looker connection #42

Open
anna-bondarieva opened this issue Nov 7, 2022 · 1 comment

Comments

@anna-bondarieva
Copy link

anna-bondarieva commented Nov 7, 2022

I am using resource "looker_connection" "bigquery_connection"

While updating the existing Looker connections / creating new ones, jdbc_additional_params attribute does not actually appear in the Looker connection.

Terraform plan and terraform apply states that it does create the jdbc_additional_params attribute:

# looker_connection.bigquery_connection["testretailer"] will be created
  + resource "looker_connection" "bigquery_connection" {
      + certificate            = (sensitive value)
      + database               = "testretailer_datamart"
      + db_timezone            = "UTC"
      + dialect_name           = "bigquery_standard_sql"
      + file_type              = ".json"
      + host                   = "***"
      + id                     = (known after apply)
      + jdbc_additional_params = "labels=client_name%3Dtestretailer"
      + name                   = "bq_testretailer_develop"
      + query_timezone         = "Australia/Sydney"
      + username               = (known after apply)
    }

When I check after that in Looker, the connection exists (other attributes update), but no change to jdbc_additional_params

@jbennett7
Copy link

jbennett7 commented Sep 28, 2023

This is the result of a typo on line 373 resource_connection.go:

if v, ok := d.GetOk("jdbc_addtional_params"); ok {

jdbc_addtional_params -> jdbc_additional_params

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants