Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crt-royale-xm29plus #7

Open
Max833 opened this issue Jul 11, 2021 · 7 comments
Open

crt-royale-xm29plus #7

Max833 opened this issue Jul 11, 2021 · 7 comments

Comments

@Max833
Copy link

Max833 commented Jul 11, 2021

Hello, thanks for your efforts. Amazing shader collection! :D

I would like to use crt-royale-xm29plus with bsnes. Is there a quark-shader for this as well?

@hizzlekizzle
Copy link
Owner

There is not. It shouldn't be terribly hard to add it, but each one of the royale duplicates adds many MBs to the repo size, so I'm reluctant to add too many. I would also need to port over the color grading LUT shader.

@Max833
Copy link
Author

Max833 commented Jul 11, 2021

Thank you for your quick reply! I see. That's a shame, but i totally understand.

I have to more questions regarding the quark-shader crt-royale (with bsnes):

  • How can I disable this TV screen bulge/curve effect?

  • No matter if I use fullscreen or pseudo-fullscreen mode, something doesn't look right there, it shows a really weird rainbow effect. Do you know how I can fix this? crt-royale-kurozumi works perfectly, though.

window mode:
1

fullscreen:
2

@hizzlekizzle
Copy link
Owner

Hmm, looks like the mask is getting scaled some in fullscreen. I'll try to reproduce it and see if I can find a solution.

For the bulge, you can disable it in the settings, which are at the top of each shader pass. I think for this one, you just need the 'geom mode' set to 0 in the last pass: https://github.com/hizzlekizzle/quark-shaders/blob/master/CRT-Royale.shader/geometry-aa-last-pass.fs#L73

@Max833
Copy link
Author

Max833 commented Jul 13, 2021

Hmm, looks like the mask is getting scaled some in fullscreen. I'll try to reproduce it and see if I can find a solution.

I think I know what's the reason for that. As soon as I enable aspect correction / overscan and go to the fullscreen mode, this is happening. Is it disabled, everything looks fine. I hope there is a way to fix this. Thank you so much that you are looking at this problem.

For the bulge, you can disable it in the settings, which are at the top of each shader pass. I think for this one, you just need the 'geom mode' set to 0 in the last pass: https://github.com/hizzlekizzle/quark-shaders/blob/master/CRT-Royale.shader/geometry-aa-last-pass.fs#L73

Thank you! It is working. :D

@Max833
Copy link
Author

Max833 commented Jul 14, 2021

Maybe this commit broke something for some shaders:

bsnes-emu/bsnes@d9f80db

@hizzlekizzle
Copy link
Owner

that's certainly possible. Can you compile before that commit and see?

@Max833
Copy link
Author

Max833 commented Jul 15, 2021

Yes, right now. But it didn't affect this...

Edit:
Okay, that's why: ^^;

"target-libretro/libretro.cpp"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants