Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unresolved maven dependency #139

Closed
fainalex opened this issue Nov 8, 2013 · 17 comments
Closed

unresolved maven dependency #139

fainalex opened this issue Nov 8, 2013 · 17 comments

Comments

@fainalex
Copy link

fainalex commented Nov 8, 2013

I've downloaded the newest version of the TL and got this unresolved POM-dependency:

eu.excitementproject
globalgraphoptimizer
1.0.3-SNAPSHOT

I can comment it now and not to use the corresponding Java-class, but later I think we can need this program code.

@adrianaf
Copy link

adrianaf commented Nov 8, 2013

Hi,

you have to download the EOP and build the graphoptimizer project: this will install it in your local maven repository and in this way the graphoptimizer will be "seen" by your TL.
At least, this is the solution that worked for me.:)

@LiliKotlerman
Copy link
Contributor

Indeed, this is a temporary problem, graphoptimizer will be moved to TL ASAP. I will report here as soon as it is done.

@gilnoh
Copy link
Member

gilnoh commented Nov 12, 2013

Even after recent merge of globalgraphoptimizer code in TL, TL still won't build due to missing globalgraphoptimizer. TL simply depends on globalgraphoptimizer, but globalgraphoptimizer is not properly setup; so TL build does not build globalgraphoptimizer.

I think, either one of the issue should be resolved.

a) either globalgraphoptimizer becomes a submodule of TL (so it builds when TL builds)
b) or let people know local maven build & installation of globalgraphoptimizer before building TL.

Meni, Lili, What is the proper sequence to build TL now? Thanks.

@gilnoh
Copy link
Member

gilnoh commented Nov 12, 2013

Eh, Meni --- maybe you have replied to a wrong issue. Maybe you have confused with the following one?

hltfbk/Excitement-Open-Platform#288

@adlerm
Copy link
Contributor

adlerm commented Nov 12, 2013

You are right...

@adlerm
Copy link
Contributor

adlerm commented Nov 12, 2013

Since the existence of the globalgraphoptimizer in the TL is temporary, we prefer not to define it as a submodule of the TL, so people should first "mvn install" the globalgraphoptimizer project, before installing tl

@fainalex
Copy link
Author

i've imported globalgraphoptimiyer package and i have many error messages in places where @OverRide is written. If one deletes them (I mean only these annotations), everything is ok

@adlerm
Copy link
Contributor

adlerm commented Nov 15, 2013

It is caused by the Java 1.5 compiler
In my project it is defined as 1.7, I don't understand why it turned to 1.5
during the import?!

On Fri, Nov 15, 2013 at 11:26 AM, fainalex [email protected] wrote:

i've imported globalgraphoptimiyer package and i have many error messages
in places where @OverRide is written. If one deletes them (I mean only
these annotations), everything is ok


Reply to this email directly or view it on GitHubhttps://github.com//issues/139#issuecomment-28556644
.

@adlerm
Copy link
Contributor

adlerm commented Nov 15, 2013

When I apply 'commit' it does not recognize any change - in which file the
java compiler is defined?

On Fri, Nov 15, 2013 at 11:29 AM, Meni Adler [email protected] wrote:

It is caused by the Java 1.5 compiler
In my project it is defined as 1.7, I don't understand why it turned to
1.5 during the import?!

On Fri, Nov 15, 2013 at 11:26 AM, fainalex [email protected]:

i've imported globalgraphoptimiyer package and i have many error messages
in places where @OverRide is written. If one deletes them (I mean only
these annotations), everything is ok


Reply to this email directly or view it on GitHubhttps://github.com//issues/139#issuecomment-28556644
.

@fainalex
Copy link
Author

I also use java 1.7

@LiliKotlerman
Copy link
Contributor

Alexandra, you mean that you use Java 1.7 and still have this problem? I also had the same error, but manually changing the project's JRE to 1.7 solved it.

@fainalex
Copy link
Author

Now to make my DemoClass run, I download both globalgraphoptimizer and tl projects, add globalgraphoptimizer as external jar library to tl. Correctly?
After all I get in any case a couple of pom errors: he wants me to add sleepycat and eu.excitement-JMWN dependencies and it's still unhappy (cannot get enything from sleepycat dependency)

@adlerm
Copy link
Contributor

adlerm commented Nov 22, 2013

Hi Alexandra

Who wants wants sleepycat and eu.excitement-JMWN dependencies?!

You just have to add to import the globalgraphoptimizer project to your
workspace

Meni

On Fri, Nov 22, 2013 at 11:08 AM, fainalex [email protected] wrote:

Now to make my DemoClass run, I download both globalgraphoptimizer and tl
projects, add globalgraphoptimizer as external jar library to tl. Correctly?
After all I get in any case a couple of pom errors: he wants me to add
sleepycat and eu.excitement-JMWN dependencies and it's still unhappy
(cannot get enything from sleepycat dependency)


Reply to this email directly or view it on GitHubhttps://github.com//issues/139#issuecomment-29058477
.

@KathrinEichler
Copy link
Contributor

Is this problem solved? If so, could you please close the issue, Alexandra? Thanks.

@fainalex
Copy link
Author

everything looks good, but as far as I understand, the globalgraphoptimizer hasn't been merged with TL and functions as a separate module.

@gilnoh
Copy link
Member

gilnoh commented Nov 25, 2013

Hello Alexandra,
I think somehow Meni's message was not clear about how to build globalgraph optimizer here. Yes, and globaloptimizer is not part of TL; but as a separate module that needs to be built and install before using TL.

The process needed for build TL is currently like this.

  1. move into globaloptimizer directory (yes, it is a separate project) in the command line
    execute the following commands.

mvn clean package install

This will install globaloptimizer in the local Maven repository.

  1. build TL as usual.

Here, do not manually add Jar to classpath, and always let Maven handle the dependencies. Also, never use IDE's classpath to resolve such Jar --- always let Maven resolve this automatically.

The only case you manually have to handle is when you put the code into an environment that does not have Maven: in such a case, you finally need to copy Jars to your server, or other environment where there is no Maven. In such a case, use the Jars produced by > mvn package
(output directory will hold generated Jar). Of course, you have to use both Jars from TL itself and globalgraph optimizer.

Note that, Meni's intention is keeping globaloptimizer in the EOP, on later stable EOP release. So, for now, Meni choose to put globalgraphoptimizer in this way along with TL source; but not as integral part of TL structure (e.g. no submodule, just a separate module).

Meni, feel very free to add any additional info. I think you can be more clear about your intention -- like you will not make globalgraphoptimizer as part of TL-submodule, because you will make it later as part of EOP, in version XX (e.g. expected next stable release in January, etc).

@fainalex
Copy link
Author

ok, so I can close it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants