Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No general comments item at the end #8

Open
julia-guo opened this issue Jan 6, 2021 · 1 comment
Open

No general comments item at the end #8

julia-guo opened this issue Jan 6, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@julia-guo
Copy link

julia-guo commented Jan 6, 2021

Currently, the script supports adding comments to each rubric item, in the following fashion:

student3 30 (A1) nice; (B1.2) wrong wq2 answer; (C2.1) Makes with warnings; (C2.2) great!

However, there is no prompt (at the very end of the script) to write general comments that are not attached to rubric items, e.g. "(A1) nice; ... ; (C2.2) great!; Excellent job overall!".

@hmontero1205 hmontero1205 added the enhancement New feature or request label Jan 8, 2021
@hmontero1205
Copy link
Owner

this will most likely involve editing the format of grades.json to have a top-level field per submission called "general-comments" or something. the more interesting question is when to prompt to enter this field.. the end of each grading question? we also want to be careful not to let the grader unintentionally overwrite older general comments..

PalashSharma20 pushed a commit to columbia-borowski/pygrader that referenced this issue Feb 13, 2025
* IMPROVE: error checking in grade.py
>
>     KEY ERROR: in def grade(), we now check if the table is in the rubric and if the item is in the table

* Remove trailing space

Co-authored-by: Dave <[email protected]>
PalashSharma20 pushed a commit to columbia-borowski/pygrader that referenced this issue Feb 13, 2025
* HW3: created rubric

* HW3: started to implement

* HW3: added a find open port

* Do more error-checking (hmontero1205#8)

* IMPROVE: error checking in grade.py
>
>     KEY ERROR: in def grade(), we now check if the table is in the rubric and if the item is in the table

* Remove trailing space

Co-authored-by: Dave <[email protected]>

* Don't add subitem to pretty-print if it's singleton rubric item (e.g. A2)

* Update README

* Setup hw3 env

* Checkout to hw3 submission tag

* Appease the linter

* HW3: implemented table A and B

    BUG: siege doesn't work

* HW3: setup, cleanup, siege, create_webroot, clean_webroot

    FIX: siege now working
    FIX: _clean_webroot() removes the webroot
    MODIFY: _create_webroot() now used dd to create the temp files

    ADD: grade.py now calles cleanup before exiting

* HW3: table D

    BUG: shutil.rmtree won't delete dir without read write

* HW3: fix _clean_webroot()

    FIX: first change the error dir to have RWE permissison

* HW3: bug fixes; complete table D

    FIX BUG: requests.get crash
    ADD TEST: D2.3 siege server on dir to get ls
    FIX BUG: kill multi-server name mistake

* HW3: testing server with slowloris attack

* HW3: server now runs in separate thread, and logs to server to file

* HW3: table B complete

* HW3: table B still not done! My bad..... ;)

* HW3: Big Update hw3 now inheriting from hw_super()

   BUGS: most of dynamic testing does not work
   FIX: bat highlighting

* HW3: fixed most linting issues

* HW3: more linting errors fixed

* HW3: fixed all pylint errors other than git errors and duplicate code

Co-authored-by: Hans Montero <[email protected]>
PalashSharma20 pushed a commit to columbia-borowski/pygrader that referenced this issue Feb 13, 2025
* IMPROVE: error checking in grade.py
>
>     KEY ERROR: in def grade(), we now check if the table is in the rubric and if the item is in the table

* Remove trailing space

Co-authored-by: Dave <[email protected]>
PalashSharma20 pushed a commit to columbia-borowski/pygrader that referenced this issue Feb 13, 2025
* HW3: created rubric

* HW3: started to implement

* HW3: added a find open port

* Do more error-checking (hmontero1205#8)

* IMPROVE: error checking in grade.py
>
>     KEY ERROR: in def grade(), we now check if the table is in the rubric and if the item is in the table

* Remove trailing space

Co-authored-by: Dave <[email protected]>

* Don't add subitem to pretty-print if it's singleton rubric item (e.g. A2)

* Update README

* Setup hw3 env

* Checkout to hw3 submission tag

* Appease the linter

* HW3: implemented table A and B

    BUG: siege doesn't work

* HW3: setup, cleanup, siege, create_webroot, clean_webroot

    FIX: siege now working
    FIX: _clean_webroot() removes the webroot
    MODIFY: _create_webroot() now used dd to create the temp files

    ADD: grade.py now calles cleanup before exiting

* HW3: table D

    BUG: shutil.rmtree won't delete dir without read write

* HW3: fix _clean_webroot()

    FIX: first change the error dir to have RWE permissison

* HW3: bug fixes; complete table D

    FIX BUG: requests.get crash
    ADD TEST: D2.3 siege server on dir to get ls
    FIX BUG: kill multi-server name mistake

* HW3: testing server with slowloris attack

* HW3: server now runs in separate thread, and logs to server to file

* HW3: table B complete

* HW3: table B still not done! My bad..... ;)

* HW3: Big Update hw3 now inheriting from hw_super()

   BUGS: most of dynamic testing does not work
   FIX: bat highlighting

* HW3: fixed most linting issues

* HW3: more linting errors fixed

* HW3: fixed all pylint errors other than git errors and duplicate code

Co-authored-by: Hans Montero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants