-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional sections don't validate correctly #121
Comments
@hmpf Not able to recreate this one, if I make a plan with an optional section and choose No for the section, it gets green check mark in the summary at the end. Could you try it once more on master? |
Closes #88. |
I make a new plan based on MBT and go directly to the middle, optional section. Click no on the toggle question, which leads to a green checkmark. When I later click Yes on the same question, the section stays green. It shouldn't unless all the questions in the activated path after the toogle also are valid. |
I see. And this works correctly for other, manual branches? |
I think so. It's really one of the areas where we need more tests. |
Okay, my investigation has revelead:
Also, MBT should exist as a fixture of sorts so we can run automated tests on it. It should also be included in the devfixtures somehow. This should be made easier by having template export, we could store an export as the fixture. This should have its own issue. |
I'm bitten by #130 now so I'll make a PR for what I have so we can release the next version. |
If the section is optional and the planner has chosen to skip the question, the section is valid.
The text was updated successfully, but these errors were encountered: