Thanks for being willing to contribute!
Working on your first Pull Request? You can learn how from this free series How to Contribute to an Open Source Project on GitHub
- Fork and clone the repo
- Run
npm run setup -s
to install dependencies and run validation - Create a branch for your PR with
git checkout -b pr/your-branch-name
Tip: Keep your
master
branch pointing at the original repository and make pull requests from branches on your fork. To do this, run:git remote add upstream https://github.com/kentcdodds/react-testing-library.git git fetch upstream git branch --set-upstream-to=upstream/master master
This will add the original repository as a "remote" called "upstream," Then fetch the git information from that remote, then set your local
master
branch to use the upstream master branch whenever you rungit pull
. Then you can make all of your pull request branches based on thismaster
branch. Whenever you want to update your version ofmaster
, do a regulargit pull
.
This project follows the all contributors specification. To
add yourself to the table of contributors on the README.md
, please use the
automated script as part of your PR:
npm run add-contributor
Follow the prompt and commit .all-contributorsrc
and README.md
in the PR. If
you've already added yourself to the list and are making a new type of
contribution, you can run it again and select the added contribution type.
Please make sure to run the tests before you commit your changes. You can run
npm run test:update
which will update any snapshots that need updating. Make
sure to include those changes (if they exist) in your commit.
There are git hooks set up with this project that are automatically installed
when you install dependencies. They're really handy, but are turned off by
default (so as to not hinder new contributors). You can opt into these by
creating a file called .opt-in
at the root of the project and putting this
inside:
pre-commit
If your PR introduced some changes in the API, you are more than welcome to
modify the Typescript type definition to reflect those changes. Just modify the
/typings/index.d.ts
file accordingly. If you have never seen Typescript
definitions before, you can read more about it in its
documentation pages
Please checkout the the open issues
Also, please watch the repo and respond to questions/bug reports/feature requests! Thanks!