Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display connection name in rabbit admin #209

Closed
rlavolee opened this issue Nov 27, 2023 · 2 comments · Fixed by #210
Closed

Display connection name in rabbit admin #209

rlavolee opened this issue Nov 27, 2023 · 2 comments · Fixed by #210

Comments

@rlavolee
Copy link
Contributor

I've seen that we can add a connection name which is useful to resolve who's who in the Rabbit Admin.

However I don't know if it's a mistake or by choice but to display connection name under its ip address in Rabbit Connection listing, connection_name should be at root level of FieldTable. Currently it's in capabilities level as shown below.

    FieldTable(
      ShortString("product") -> ShortString("Lepus"),
      ShortString("version") -> ShortString(BuildInfo.version),
      ShortString("platform") -> ShortString("scala"),
      ShortString("scala-version") -> ShortString(BuildInfo.scalaVersion),
      ShortString("capabilities") -> FieldTable(
        ShortString("publisher_confirms") -> true,
        ShortString("authentication_failure_close") -> true,
        ShortString("consumer_cancel_notify") -> true,
        ShortString("basic.nack") -> true,
        ShortString("connection.blocked") -> true
      ).updated(ShortString("connection_name"), connectionName)
    )

Are you interested in a fix ? :)

@hnaderi
Copy link
Owner

hnaderi commented Nov 27, 2023

It's a mistake for sure! 😅
It supposed to be after the next parenthesis.

@hnaderi
Copy link
Owner

hnaderi commented Nov 27, 2023

Thank you! I just pushed the bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants