Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minphase filter does not sound well... #16

Open
hoene opened this issue Jun 4, 2017 · 2 comments
Open

Minphase filter does not sound well... #16

hoene opened this issue Jun 4, 2017 · 2 comments

Comments

@hoene
Copy link
Owner

hoene commented Jun 4, 2017

@richardpl
Another issue I found is if previously call mysofa_load, and later mysofa_open with same sofa file and sample rate to one reported in mysofa_load, length of IRs: N changes.
The resulted IRs are bad, because I get artifacts when filtering in time domain, the one in frequency domain are still present but much less noticeable.

hoene added a commit that referenced this issue Jun 15, 2017
@richardpl
Copy link
Contributor

Actually the minphase code seems ok after enabling it once again, it was bug in sofalizer filter implementation - non-power of 2 IR length would cause ringbuffer to be of invalid, not enough big size causing artifacts.
Still there should be easy way to toggle this feature on or off, via special call: mysofa_open_advanced2 or mysofa_open_advanced_minphase().

@hoene
Copy link
Owner Author

hoene commented Dec 23, 2018

Thank you for testing.
I will write a patch to extend the lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants