Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All project pages should contain links to live sites #4

Open
jamiefolsom opened this issue Oct 12, 2017 · 4 comments
Open

All project pages should contain links to live sites #4

jamiefolsom opened this issue Oct 12, 2017 · 4 comments
Assignees

Comments

@jamiefolsom
Copy link
Member

jamiefolsom commented Oct 12, 2017

See: http://hofstradrc.org/projects/ and click through all, to be sure links are live.

  • So far, at least RSLT and AccessScholar don't: it's the blue "View Project" button at bottom right:

screenshot 2017-10-12 15 37 50

@jamiefolsom
Copy link
Member Author

jamiefolsom commented Oct 16, 2017

Hey @tezcatlipoca -- start with the issues on this site -- they're straightforward, and more pressing, too. I will put them at the top of the list in zenhub. Thanks!

[EDIT] Actually, so far it's just this one, but a good one to start from, as you will get the lay of the land too.

@feralresearch
Copy link
Contributor

@jamiefolsom

Four projects were missing links:
Octoroon, Access Scholar, Digital Van Mander, RSLT

I fixed the link for "Access Scholar" but I couldn't find the others

I also fixed a bug in the liquid logic so that if the project has no URL, the button will not appear, so at least now we won't have a broken button appearing on the other sites.

Branch is as-linkfix

@jamiefolsom
Copy link
Member Author

👍 for removing the button where there's no link.

@feralresearch
Copy link
Contributor

Fixed RSLT too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants