Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Pouch takes a .webhapp instad of a .happ + ui.zip #9

Open
mattyg opened this issue Sep 8, 2023 · 3 comments
Open

[Enhancement] Pouch takes a .webhapp instad of a .happ + ui.zip #9

mattyg opened this issue Sep 8, 2023 · 3 comments

Comments

@mattyg
Copy link
Contributor

mattyg commented Sep 8, 2023

Does it make sense for the pouch to hold a .webhapp, instead of both a .happ and a ui.zip? Seems simpler, right?

@matthme
Copy link
Collaborator

matthme commented Sep 8, 2023

Absolutely, I actually wanted to start implementing this recently but ended up not prioritizing it. One thing that held me off from implementing it is that unpacking a webhapp is easiest via using the hc CLI and this would require hc to be present in the environment, i.e. probably nix shell. I guess that's acceptable but relying on nix seemed like an additional point of friction as well.

@mattyg
Copy link
Contributor Author

mattyg commented Sep 8, 2023

Absolutely, I actually wanted to start implementing this recently but ended up not prioritizing it. One thing that held me off from implementing it is that unpacking a webhapp is easiest via using the hc CLI and this would require hc to be present in the environment, i.e. probably nix shell. I guess that's acceptable but relying on nix seemed like an additional point of friction as well.

We should be able to use hc_bundle directly, right?: https://github.com/holochain/holochain/blob/78ae6e3a7d69a906e6112b09fada7ac43b0b1eea/crates/hc_bundle/src/cli.rs#L192

@matthme
Copy link
Collaborator

matthme commented Sep 11, 2023

Note that the unpacking needs to happen at build time, not runtime. But it might still be possible to use it in a build.rs file, will have to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants