Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Dna Properties type #392

Open
mattyg opened this issue Dec 31, 2024 · 0 comments
Open

Inconsistent Dna Properties type #392

mattyg opened this issue Dec 31, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mattyg
Copy link
Collaborator

mattyg commented Dec 31, 2024

The DNA Properties type specified in the integrity zomes is

pub struct Properties {
    pub created: Timestamp,
    pub privacy: Privacy,
    pub progenitor: AgentPubKey,
}

But when the UI is cloning cells, it uses the following properties type:

interface Properties {
    created: Timestamp,
    privacy: Privacy,
    progenitor: AgentPubKeyB64
}

It's not clear to me if serde serialization is handling converting AgentPubKeyB64 -> AgentPubKey, and thus there is no issue other than confusion in the codebase, OR if it is not doing this conversion and thus some integrity rules are not being applied as expected, which will require a breaking change to fix.

@mattyg mattyg added the bug Something isn't working label Dec 31, 2024
@mattyg mattyg moved this to Ready for Holochain Foundation in Volla Messages Dec 31, 2024
@mattyg mattyg removed the status in Volla Messages Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant