Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install instructions don't work (npm install fails to find holochain-conductor-api#dump-full-state) #64

Open
carlgieringer opened this issue May 10, 2022 · 1 comment

Comments

@carlgieringer
Copy link
Contributor

Following the instructions in the README for local development, the command npm install fails with this output:

[nix-shell:~/code/github/carlgieringer/holochain-gym.github.io]$ npm install
npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
npm ERR! code 1
npm ERR! Command failed: git checkout dump-full-state
npm ERR! error: pathspec 'dump-full-state' did not match any file(s) known to git
npm ERR! 

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/transverna/.npm/_logs/2022-05-10T14_22_55_043Z-debug.log

Looking in the debug.log, I see:

...
info lifecycle @holochain-open-dev/[email protected]~postpack: @holochain-open-dev/[email protected]
24 silly pacote git manifest for @holochain-open-dev/core-types@git+https://github.com/holochain-open-dev/core-types.git#build fetched in 2186ms
25 silly resolveWithNewModule @holochain-open-dev/[email protected] checking installable status
26 silly fetchPackageMetaData error for @holochain/conductor-api@github:holochain/holochain-conductor-api#dump-full-state Command failed: git checkout dump-full-state
26 silly fetchPackageMetaData error: pathspec 'dump-full-state' did not match any file(s) known to git
27 timing stage:rollbackFailedOptional Completed in 0ms
28 timing stage:runTopLevelLifecycles Completed in 16612ms
...
@carlgieringer
Copy link
Contributor Author

It looks like holochain-playground/core at HEAD depends on github:holochain/holochain-conductor-api#dump-full-state (package.json). Going to https://github.com/holochain/holochain-conductor-api redirects me to https://github.com/holochain/holochain-client-js. In that repo, I can't find a branch dump-full-state.

So I think we need to try updating the dependency in holochain-playground/core to /holochain/holochain-client-js. Hopefully it just works, but, if not, we might need to understand what was previously in the dump-full-state branch.

(While looking into this issue, I noticed a couple of other things:)

holochain-playground/core also depends on file:~/projects/holochain/open-dev/core-types, which won't work on my machine since I have a different folder structure.

This might be fixed by updating the dependency to holochain-open-dev/core-types.

(Also, why is the holochain-playground/core repo archived if the holochain-gym actively depends on it?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant