Update cell provisioning types #318
Conversation
| @@ -429,6 +427,12 @@ export type Location = | |||
| * Get file from URL | |||
| */ | |||
| url: string; | |||
| } | |||
| | { | |||
There was a problem hiding this comment.
This in particular feels weird to me -- an empty struct as a union variant. It's only there because Location gets intersected with AppRoleDnaManifest, because the corresponding stuff (that is, the optional AppRoleDnaManifest::location field's enum variant value) gets collapsed into AppRoleDnaManifest and we've got to find some similar way of modelling that.
|
Tests were failing after the smoke cleared; converted to draft. |
|
Currently getting timeouts with the |
|
The |
CellProvisioningbroke compatibility at 0.4; there's now aprotectedflag forUseExisting. This adds that flag and also takes the opportunity to addCloneOnlywhich was previously missing.I'd love some feedback on the TS idioms I've used here; I don't know how idiomatic or ergonomic they are.
Tests (including, but not only, the new ones I added) were failing locally due to API timeouts; hopefully that isn't masking any conductor errors (I believe I've fixed them all, but I'm not sure).
Closes #317 .