Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure site builds to fail on error #236

Open
maximlt opened this issue Nov 29, 2022 · 0 comments
Open

Configure site builds to fail on error #236

maximlt opened this issue Nov 29, 2022 · 0 comments

Comments

@maximlt
Copy link
Collaborator

maximlt commented Nov 29, 2022

Currently building a site with NBSite doesn't fail if an error occurs while running a notebook. There should be an option to configure the build to fail in such case. Ideally, it would not fail as soon as an error occurs but keep running all the notebooks, and only then reports the failures.

When this functionality is found/implemented, we would enable it over the different projects. This would need to be done incrementally as it's likely some of the current site builds would immediately fail. We'd need to decide whether enabling this during a release is a good idea or not. I'd suggest that this should be enabled on all the scheduled runs though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant