From a9f8c76a6521756ab922f4b59b768782216e2a7c Mon Sep 17 00:00:00 2001
From: Christoph Deil <Deil.Christoph@gmail.com>
Date: Tue, 13 Aug 2024 13:14:34 +0100
Subject: [PATCH] Fix some PyCharm warnings (#7120)

Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
---
 README.md                                                     | 2 +-
 binder/jupyter-panel-apps-server/jupyter_panel_apps_server.py | 2 +-
 codecov.yml                                                   | 2 +-
 examples/how_to/custom/react/material_ui.py                   | 2 --
 panel/io/cache.py                                             | 1 -
 scripts/panelite/generate_panelite_content.py                 | 1 -
 scripts/panelite/test/test_panelite.py                        | 4 ++--
 7 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/README.md b/README.md
index c8b12f06e0..072d059313 100644
--- a/README.md
+++ b/README.md
@@ -19,7 +19,7 @@ Enjoying Panel? Show your support with a [Github star](https://github.com/holovi
 <tbody>
 <tr>
 <td>Downloads</td>
-<td><a href="https://pypistats.org/packages/panel" alt="PyPi Downloads"><img src="https://img.shields.io/pypi/dm/panel?label=pypi" /></a> <a href="https://anaconda.org/pyviz/panel" alt="Conda Downloads"><img src="https://pyviz.org/_static/cache/panel_conda_downloads_badge.svg" /></a></td>
+<td><a href="https://pypistats.org/packages/panel"><img src="https://img.shields.io/pypi/dm/panel?label=pypi" alt="PyPi Downloads" /></a> <a href="https://anaconda.org/pyviz/panel"><img src="https://pyviz.org/_static/cache/panel_conda_downloads_badge.svg" alt="Conda Downloads" /></a></td>
 </tr>
 <tr>
 <td>Build Status</td>
diff --git a/binder/jupyter-panel-apps-server/jupyter_panel_apps_server.py b/binder/jupyter-panel-apps-server/jupyter_panel_apps_server.py
index d661d41dac..847c6c6cbb 100644
--- a/binder/jupyter-panel-apps-server/jupyter_panel_apps_server.py
+++ b/binder/jupyter-panel-apps-server/jupyter_panel_apps_server.py
@@ -20,7 +20,7 @@ def get_apps():
     return [
         app
         for app in glob("examples/gallery/**/*.ipynb", recursive=True)
-        if not app in DONT_SERVE
+        if app not in DONT_SERVE
     ]
 
 
diff --git a/codecov.yml b/codecov.yml
index b6ee7c18e8..bec5dc77f5 100644
--- a/codecov.yml
+++ b/codecov.yml
@@ -7,4 +7,4 @@ coverage:
         threshold: 0.5%
 
 comment:
-  require_changes: yes
+  require_changes: true
diff --git a/examples/how_to/custom/react/material_ui.py b/examples/how_to/custom/react/material_ui.py
index 262ac7ee29..a63ea4eef6 100644
--- a/examples/how_to/custom/react/material_ui.py
+++ b/examples/how_to/custom/react/material_ui.py
@@ -1,5 +1,3 @@
-import pathlib
-
 import param
 
 import panel as pn
diff --git a/panel/io/cache.py b/panel/io/cache.py
index 54b3b6d3be..8a806b879c 100644
--- a/panel/io/cache.py
+++ b/panel/io/cache.py
@@ -14,7 +14,6 @@
 import sys
 import threading
 import time
-import unittest
 import unittest.mock
 import weakref
 
diff --git a/scripts/panelite/generate_panelite_content.py b/scripts/panelite/generate_panelite_content.py
index 1038017f07..a6251e8cc4 100644
--- a/scripts/panelite/generate_panelite_content.py
+++ b/scripts/panelite/generate_panelite_content.py
@@ -1,7 +1,6 @@
 """
 Helper script to convert and copy example notebooks into JupyterLite build.
 """
-import hashlib
 import json
 import os
 import pathlib
diff --git a/scripts/panelite/test/test_panelite.py b/scripts/panelite/test/test_panelite.py
index a79cd6cc32..e969737963 100644
--- a/scripts/panelite/test/test_panelite.py
+++ b/scripts/panelite/test/test_panelite.py
@@ -57,7 +57,7 @@ def get_panelite_nb_paths():
     nbs = list(FILES.glob('*/*/*.ipynb')) + list(FILES.glob('*/*.*'))
     for nb in nbs:
         path = str(nb).replace("\\", "/").split("files/")[-1]
-        if path.endswith(".ipynb") and not ".ipynb_checkpoints" in path:
+        if path.endswith(".ipynb") and ".ipynb_checkpoints" not in path:
             yield path
 PATHS_WITH_NOTHING_TO_TEST = [
     "gallery/demos/attractors.ipynb",
@@ -66,7 +66,7 @@ def get_panelite_nb_paths():
     "gallery/demos/nyc_taxi.ipynb",
     "gallery/demos/portfolio-optimizer.ipynb",
 ]
-PATHS = list(path for path in get_panelite_nb_paths() if not path in PATHS_WITH_NOTHING_TO_TEST)
+PATHS = list(path for path in get_panelite_nb_paths() if path not in PATHS_WITH_NOTHING_TO_TEST)
 PATHS_WITHOUT_ISSUES = list(path for path in PATHS if path not in NOTEBOOK_ISSUES)
 PATHS_WITH_ISSUES = list(path for path in PATHS if path in NOTEBOOK_ISSUES)