Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaceCommand and addCommandList crash blink from time to time #70

Open
yury opened this issue Nov 8, 2018 · 2 comments
Open

replaceCommand and addCommandList crash blink from time to time #70

yury opened this issue Nov 8, 2018 · 2 comments

Comments

@yury
Copy link
Contributor

yury commented Nov 8, 2018

Spotted in crashlogs from App Store.

image

image

iOS 11,12
devices: iPhone, iPad

@holzschu
Copy link
Owner

holzschu commented Nov 8, 2018

Interesting. If I read that correctly, the issue comes from CFDictionaryCreateMutableCopy. I'm going to have a look, but I don't think this command is supposed to crash.

@holzschu
Copy link
Owner

holzschu commented Nov 8, 2018

I think the last line of replaceCommand should be:

commandList = [mutableDict copy];

instead of:

commandList = [mutableDict mutableCopy];

See commit ea25d0e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants