fix: docker add to homarr layout overflow #2441
Open
+24
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuel-rw
force-pushed
the
fix/docker-add-to-homarr-layout-overflow
branch
from
9944456 to
58988a6
Compare
|
Here's the code health analysis summary for commits Analysis Summary
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
manuel-rw
force-pushed
the
fix/docker-add-to-homarr-layout-overflow
branch
from
58988a6 to
0770aee
Compare
Meierschlumpf
requested changes
Feb 28, 2025
| <TextInput {...form.getInputProps(`containerUrls.${index}`)} /> | ||
| </Group> | ||
| </List.Item> | ||
| ))} | ||
| </List> | ||
| <Group justify="end"> | ||
| <Button onClick={actions.closeModal} variant="light"> | ||
| <Button onClick={actions.closeModal} variant="light" px={"xl"}> |
| <Group justify="space-between"> | ||
| <Text>{container.name}</Text> | ||
| <Group justify="space-between" wrap={"nowrap"}> | ||
| <Text lineClamp={1}>{container.name}</Text> |
There was a problem hiding this comment.
Maybe we could also change the size of the modal to something bigger
| {t("common.action.cancel")} | ||
| </Button> | ||
| <Button disabled={!form.isValid()} type="submit"> | ||
| <Button disabled={!form.isValid()} type="submit" px={"xl"}> |
There was a problem hiding this comment.
Remove disabled={!form.isValid()}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homarr
Thank you for your contribution. Please ensure that your pull request meets the following pull request:
pnpm build, autofix withpnpm format:fix)devbranchx,y,ior any abbrevation)