Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(widget): add minecraft server status widget #1801

Merged
merged 2 commits into from
Dec 31, 2024
Merged

feat(widget): add minecraft server status widget #1801

merged 2 commits into from
Dec 31, 2024

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Using the following api: https://api.mcsrvstat.us/
image

@Meierschlumpf Meierschlumpf added the enhancement New feature or request label Dec 28, 2024
@Meierschlumpf Meierschlumpf self-assigned this Dec 28, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner December 28, 2024 14:49
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Dec 28, 2024 •
edited
Loading

Here's the code health analysis summary for commits c8228b9..551a2a5. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 28, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.63% 7846 / 36271
🔵 Statements 21.63% 7846 / 36271
🔵 Functions 24.69% 285 / 1154
🔵 Branches 61.76% 861 / 1394
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/api/src/router/widgets/index.ts 100% 100% 100% 100%
packages/api/src/router/widgets/minecraft.ts 39.28% 100% 100% 39.28% 15-19, 22-34
packages/cron-jobs/src/index.ts 100% 100% 100% 100%
packages/cron-jobs/src/jobs/minecraft-server-status.ts 26.66% 100% 100% 26.66% 13-24
packages/definitions/src/widget.ts 100% 100% 100% 100%
packages/redis/src/index.ts 100% 100% 100% 100%
packages/redis/src/lib/channel.ts 22.36% 100% 14.28% 22.36% 28-38, 44-48, 50-52, 71-73, 79-80, 85-86, 92-93, 112-121, 128-154, 159-160, 166-167, 172-174, 177-184, 187-194, 197-198, 201-259, 262-283, 297-299, 301-302, 310-313, 324-326, 333-335, 341-343, 348-349
packages/request-handler/src/minecraft-server-status.ts 84% 100% 0% 84% 12-16
packages/request-handler/src/lib/cached-widget-request-handler.ts 44.44% 100% 50% 44.44% 25-34
packages/widgets/src/index.tsx 52.94% 100% 0% 52.94% 67-83, 98-107
packages/widgets/src/minecraft/server-status/component.tsx 0% 0% 0% 0% 1-61
packages/widgets/src/minecraft/server-status/index.ts 100% 100% 100% 100%
Generated in workflow #4361 for commit 551a2a5 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf mentioned this pull request Dec 30, 2024
Merged
@Meierschlumpf Meierschlumpf merged commit 0ebf4bc into dev Dec 31, 2024
13 checks passed
@Meierschlumpf Meierschlumpf deleted the minecraft-server-status branch December 31, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-rw manuel-rw manuel-rw approved these changes

Assignees

@Meierschlumpf Meierschlumpf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meierschlumpf @manuel-rw