Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): replace anonymous docker volume with env variable for encrypting secrets #1809

Merged
merged 10 commits into from
Dec 31, 2024

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

THIS IS A BREAKING CHANGE!

Closes #1808

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Dec 29, 2024
@Meierschlumpf Meierschlumpf added this to the 1.0.0 milestone Dec 29, 2024
@Meierschlumpf Meierschlumpf self-assigned this Dec 29, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner December 29, 2024 21:06
Copy link

deepsource-io bot commented Dec 29, 2024

Here's the code health analysis summary for commits 23c7d0b..c63005a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Dec 29, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.52% 7804 / 36260
🔵 Statements 21.52% 7804 / 36260
🔵 Functions 24.73% 284 / 1148
🔵 Branches 61.84% 859 / 1389
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/next.config.mjs 0% 0% 0% 0% 1-43
e2e/shared/create-homarr-container.ts 0% 0% 0% 0% 1-26
packages/auth/env.mjs 57.14% 20% 100% 57.14% 12-21, 32-46, 53-57, 70-77, 81-93
packages/common/env.mjs 100% 0% 100% 100%
packages/common/src/encryption.ts 100% 100% 100% 100%
Generated in workflow #4404 for commit c63005a by the Vitest Coverage Report Action

manuel-rw
manuel-rw previously approved these changes Dec 29, 2024
@Meierschlumpf Meierschlumpf changed the title fix(env): remove unused auth-secret env variable fix(docker): replace anonymous docker volume with env variable for encrypting secrets Dec 29, 2024
manuel-rw
manuel-rw previously approved these changes Dec 30, 2024
@manuel-rw
Copy link
Member

e2e is failing, please have a look

@Meierschlumpf Meierschlumpf merged commit 56b57ad into dev Dec 31, 2024
13 checks passed
@Meierschlumpf Meierschlumpf deleted the fix-anonymous-secrets-volume branch December 31, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: TRPCClientError: error:1C800064:Provider routines::bad decrypt
2 participants