Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

too dark map issue when using dark theme #15587

Closed
3 tasks done
kiki3529-0 opened this issue Feb 24, 2023 · 15 comments
Closed
3 tasks done

too dark map issue when using dark theme #15587

kiki3529-0 opened this issue Feb 24, 2023 · 15 comments
Assignees
Labels

Comments

@kiki3529-0
Copy link

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

Good morning
when I use the dark theme, the map is really too dark to see the streets well, is it possible to make it much lighter?
THANKS

Describe the behavior you expected

too dark map issue when using dark theme

Good morning
when I use the dark theme, the map is really too dark to see the streets well, is it possible to make it much lighter?
THANKS

Steps to reproduce the issue

1.companion app
2.dark theme
3.person
4 map
...

What version of Home Assistant Core has the issue?

Home Assistant 2023.2.5 Supervisor 2023.01.1 Operating System 9.5 Interface utilisateur : 20230202.0 - latest

What was the last working version of Home Assistant Core?

Home Assistant 2023.2.5 Supervisor 2023.01.1 Operating System 9.5 Interface utilisateur : 20230202.0 - latest

In which browser are you experiencing the issue with?

No response

Which operating system are you using to run this browser?

No response

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

@matthiasdebaat
Copy link
Collaborator

What type of device are you using? Is it the same on desktop and mobile? Can you share a screenshot and describe what parts should be improved?

@kiki3529-0
Copy link
Author

kiki3529-0 commented Feb 24, 2023 via email

@ildar170975
Copy link
Contributor

There is an inconsistency with maps in a dark mode.
Check this code:

  - type: horizontal-stack
    cards:
      - type: map
        entities:
          - person.ildar
      - type: map
        entities:
          - person.ildar
        dark_mode: false
      - type: map
        entities:
          - person.ildar
        dark_mode: true

Light default mode:
изображение

Dark default mode:
изображение

The issue was described here: #13333
And no any movement for this issue.

And see a difference since 2022.8 (described here - #13333 (comment)):
изображение

@kiki3529-0
Copy link
Author

kiki3529-0 commented Feb 25, 2023 via email

@ildar170975
Copy link
Contributor

@kiki3529-0
your reply is not clear, probably because you are answering via mail.

@github-actions
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 26, 2023
@ildar170975
Copy link
Contributor

up

@github-actions github-actions bot removed the stale label May 26, 2023
@smithbill17
Copy link

It seems like numerous requests to have a light map card whilst Home Assistant is in dark-mode, are being ignored?

I think, from what I've read, this is how it used to work? Why isn't this a straight forward request? It would make for a much more useable map view whilst the rest of Home Assistant is operating in the more eye-friendly Dark Mode.

@christophwen
Copy link
Contributor

I will try to fix this issue.

christophwen added a commit to christophwen/home-assistant-frontend that referenced this issue Jun 28, 2023
- hover background color of zoom control in dark mode
- map light mode when dark theme is used
- background color of zoom control with map dark mode when light theme is used
christophwen added a commit to christophwen/home-assistant-frontend that referenced this issue Jun 28, 2023
christophwen added a commit to christophwen/home-assistant-frontend that referenced this issue Jul 5, 2023
- Additionally fixed unpleasant horizontal scrollbar in map editor
christophwen added a commit to christophwen/home-assistant-frontend that referenced this issue Sep 26, 2023
- hover background color of zoom control in dark mode
- map light mode when dark theme is used
- background color of zoom control with map dark mode when light theme is used
christophwen added a commit to christophwen/home-assistant-frontend that referenced this issue Sep 26, 2023
christophwen added a commit to christophwen/home-assistant-frontend that referenced this issue Sep 26, 2023
- Additionally fixed unpleasant horizontal scrollbar in map editor
@github-actions
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 26, 2023
@smithbill17
Copy link

With Companion App 2023.9.2-full set to Theme = Dark, then Map Card map only shows in a very dark or slightly less Dark Mode regardless of the Dark Mode toggle being on or off (Home Assistant 2023.9.3)

@github-actions github-actions bot removed the stale label Sep 26, 2023
@kiki3529-0
Copy link
Author

kiki3529-0 commented Sep 26, 2023 via email

christophwen added a commit to christophwen/home-assistant-frontend that referenced this issue Nov 16, 2023
- hover background color of zoom control in dark mode
- map light mode when dark theme is used
- background color of zoom control with map dark mode when light theme is used
christophwen added a commit to christophwen/home-assistant-frontend that referenced this issue Nov 16, 2023
christophwen added a commit to christophwen/home-assistant-frontend that referenced this issue Nov 16, 2023
- Additionally fixed unpleasant horizontal scrollbar in map editor
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 25, 2023
@cociweb
Copy link

cociweb commented Dec 27, 2023

+1 The dark is invisible on the dark side too....

@github-actions github-actions bot removed the stale label Dec 27, 2023
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 26, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
bramkragten pushed a commit that referenced this issue Apr 24, 2024
* Fix visual map issues (#15587)

- hover background color of zoom control in dark mode
- map light mode when dark theme is used
- background color of zoom control with map dark mode when light theme is used

* Fix breaking change (#15587)

* Change theme mode selection to use dropdown (#15587)

- Additionally fixed unpleasant horizontal scrollbar in map editor

* Add yaml migration, fix force light/dark options

---------

Co-authored-by: Christoph Wen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants