-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radio Station names are truncated in Radio Browser in mobile app #18225
Comments
Reposting my comment here from the original core/issues/101704 to add the info here: Thanks for the nice bug report, I don't develop at home assistant, but as a developer I appreciate. I came to GitHub to file the same report, so, +1 here, following this and hoping for a fix soon. The problem is also very noticeable on the German language stations. There are hundreds of them and stations often have multiple streams.
A correction, this is an issue everywhere! I got a medium/big phone (pixel 7) and also tested on my 15" laptop. On the bigger screen the grid is rendered in a dialog/popup that still truncate the names. Thanks! Following the thread! |
I propose a grid / list toggle option in #18256. I'm not much of a CSS designer so I'll leave dealing with the truncation for someone else, but this should help alleviate your difficulties. |
Following the PR in Media Browser (#18256), the suggestion was made that Radio Browser could just default to list view rather than requiring a change in Media Browser to allow users to switch views. How hard is that? |
@dunxd not hard, the integration provides a media class, based on that type the layout is chosen currently: Changing that to something else will change the layout, or maybe we even have to add a new one. This are the current settings: frontend/src/data/media-player.ts Lines 116 to 167 in d2caed2
With these changes for example: diff --git a/homeassistant/components/radio_browser/media_source.py b/homeassistant/components/radio_browser/media_source.py
index dffbdc42db..1fcb2b0bad 100644
--- a/homeassistant/components/radio_browser/media_source.py
+++ b/homeassistant/components/radio_browser/media_source.py
@@ -82,12 +82,12 @@ class RadioMediaSource(MediaSource):
return BrowseMediaSource(
domain=DOMAIN,
identifier=None,
- media_class=MediaClass.CHANNEL,
+ media_class=MediaClass.DIRECTORY,
media_content_type=MediaType.MUSIC,
title=self.entry.title,
can_play=False,
can_expand=True,
- children_media_class=MediaClass.DIRECTORY,
+ children_media_class=MediaClass.MUSIC,
children=[
*await self._async_build_popular(radios, item),
*await self._async_build_by_tag(radios, item), |
Any updates here? |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. |
Checklist
Describe the issue you are experiencing
When viewing the list of radio stations with the mobile app, the names are truncated cutting off everything after the first 9 characters in some cases. This makes it impossible to locate a specific radio station - e.g. BBC has 109 entries in the Radio Browser database starting with "BBC Radio". The icons for the radio station are often not helpful to identify the specific station, so the text needs to be.
I expect this is an issue specific to smaller devices, as the truncation is less of an issue when viewing Home Assistant interface through a desktop browser where there is more width available.
Describe the behavior you expected
It would be better if the entire name was wrapped if necessary rather than truncating away useful information. A list option would be nice, rather than limiting the number of items displayed based on an often empty or info free image. In cases where multiple streams are available for the same station, it would be even more helpful to have some way of displaying additional info to tell the difference between the entries, such as the format, bitrate etc. For example, BBC Radio 6 Music has 6 entries in the Radio Browser database, all named the same, but with different qualities.
Steps to reproduce the issue
What version of Home Assistant Core has the issue?
2023.10.3
What was the last working version of Home Assistant Core?
No response
In which browser are you experiencing the issue with?
Companion App 2023.10.2-full
Which operating system are you using to run this browser?
Android 13
State of relevant entities
No response
Problem-relevant frontend configuration
No response
Javascript errors shown in your browser console/inspector
No response
Additional information
Originally logged at home-assistant/core#101704 where it was suggested I repost it here. Someone suggested it may be an issue with the media browser, and indeed the truncation happens there, so anything other than a short filename with most relevant info at the start of not useful.
The text was updated successfully, but these errors were encountered: