-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status bar color follows wrong color variable #2752
Comments
I had to revert the PR, the app theme color doesn't always match the navigation bar, which makes it look weird in some situations like dark mode using the default themes |
@bgoncal I think that should be fixed by this: |
Looks like the fix doesn't work. I'll try to get it patched up. |
Let's wait a bit until this ir tested in the frontend and we are sure it will behave as expected, but I will keep this on the radar, feel free to drop a message in a week or two |
Sounds good. I opened the fix: |
Closing this issue since both frontend and mobile PR's were merged, let me know in case its not behaving as expected |
Thank you. |
iOS device model, version and app version
Model Name: iPhone 15 Pro
Software Version: iOS 17.4.1
App version: 2024.624
Home Assistant Core Version
2024.4.4, 2024.5.0-b4
Describe the bug
The color of the status bar follows the
--app-header-background-color
variable. This is inconsistent with the browser where it follows--app-theme-color
. It'd be nice to use that variable if it's set.To Reproduce
Create a theme which sets
app-theme-color
:Expected behavior
--app-theme-color
should be used if it's set. The header color could still be used as a fallback.Screenshots
Additional context
The frontend sets the theme color here:
https://github.com/home-assistant/frontend/blob/7120ad99b9bdd3d6dc648deb6ae5285d986f8744/src/state/themes-mixin.ts#L134
In the default theme the value of
--app-header-background-color
and--app-theme-color
is the same.The text was updated successfully, but these errors were encountered: