Support custom DNS configuration on auto #5258
Conversation
WalkthroughWalkthroughThe recent changes enhance network configuration capabilities by introducing automatic handling of DNS nameservers. A new attribute, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant NetworkManager
participant IpConfig
participant DNSService
User->>NetworkManager: Request Configuration
NetworkManager->>IpConfig: Create Instance
IpConfig->>NetworkManager: Check DNS Settings
alt DNS settings found
IpConfig-->>NetworkManager: Set nameservers_auto to False
NetworkManager->>DNSService: Configure DNS with specified nameservers
else No DNS settings
IpConfig-->>NetworkManager: Set nameservers_auto to True
NetworkManager->>DNSService: Configure DNS with automatic nameservers
end
NetworkManager-->>User: Return Configuration
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @agners,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
bfc67dc1216b3d70fbf9f3ac4b99c2d3b535e12e- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <[email protected]>"[email protected]" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
agners
force-pushed
the
support-static-dns-configuration
branch
2 times, most recently
from
1cb1a5e to
b780b84
Compare
There was a problem hiding this comment.
Hello @agners,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
b780b847e65be4ecd9be491e124540d3d3e97b9f- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <[email protected]>"[email protected]" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
agners
force-pushed
the
support-static-dns-configuration
branch
from
b780b84 to
d265afa
Compare
agners
force-pushed
the
support-static-dns-configuration
branch
2 times, most recently
from
c1747ab to
3ee79b0
Compare
So far, when the network setting is set to auto, we don't allow a custom DNS configuration. However, it is a perfectly valid use case to provide custom DNS configuration while using automatic IP configuration (e.g. DHCP). Especially when the DHCP server doesn't provide a DNS server. In this case, systemd-resolved (at least on Home Assistant OS) falls back to Cloudflare. This might not what the user wants. Customze the DNS setting allows to set a custom fallback DNS server or override a potential non-working DHCP provided one.
agners
force-pushed
the
support-static-dns-configuration
branch
from
3ee79b0 to
1e9a3d7
Compare
|
Closing this one as we took a different route with #5262. |
Proposed change
So far, when the network setting is set to auto, we don't allow a custom DNS configuration. However, it is a perfectly valid use case to provide custom DNS configuration while using automatic IP configuration (e.g. DHCP). Especially when the DHCP server doesn't provide a DNS server. In this case, systemd-resolved (at least on Home Assistant OS) falls back to Cloudflare. This might not what the user wants. Customze the DNS setting allows to set a custom fallback DNS server or override a potential non-working DHCP provided one.
Type of change
Additional information
Checklist
ruff format supervisor tests)If API endpoints of add-on configuration are added/changed:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation