Skip to content

Commit

Permalink
Bugfix that broke everything (details below) (#238, #271, #290)
Browse files Browse the repository at this point in the history
Original problem: feedback wasn't engaged when economizer wasn't configured
due to a typo

Collateral and deal breaker: fixing the bug makes test cases stall, though
the application somehow keeps working.

This very likely pinpoints the root cause of #290.
  • Loading branch information
climategadgets committed Oct 11, 2023
1 parent d09a207 commit fc34be5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dz3r-model/src/main/java/net/sf/dz3r/model/Zone.java
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ public Flux<Signal<ZoneStatus, String>> compute(Flux<Signal<Double, String>> in)

var source = Optional.ofNullable(economizer)
.map(eco -> eco.compute(combined))
.orElse(in);
.orElse(combined);

// Since the zone doesn't need the payload, but the thermostat does, need to translate the input
var stage0 = source
Expand Down

0 comments on commit fc34be5

Please sign in to comment.