Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Thermostat and Zone to exist without having a setpoint #267

Open
climategadgets opened this issue Jul 5, 2023 · 0 comments
Open

Allow Thermostat and Zone to exist without having a setpoint #267

climategadgets opened this issue Jul 5, 2023 · 0 comments
Labels
enhancement process control reactive-only Will be fixed in Reactive branches only setpoint usability

Comments

@climategadgets
Copy link
Member

climategadgets commented Jul 5, 2023 •
edited
Loading

Existing Behavior

Control logic is dead set on having a setpoint from the get go and refuses to work without it. This forces some value of a setpoint to be injected at instantiation, and "default" reasonable setpoint value is different for different zones and different modes, hence, impractical.

Desired Behavior

Allow setpoint to be unspecified at startup so that the control logic can interpret it exactly as it does when the signal source for that zone is missing.

Additional Context

Same applies to the economizer - as long as permanent configuration is provided, missing changeoverDelta and target may be interpreted as "keep the economizer off", and missing keepHvacOn may be configured to a sensible default.
climategadgets added a commit that referenced this issue Apr 6, 2024
@climategadgets
Economizer settings are now optional in the configuration (#267, #311)
e696df2
climategadgets added a commit that referenced this issue Apr 10, 2024
@climategadgets
Economizer settings are now optional in the configuration (#267, #311)
936c767
@climategadgets climategadgets mentioned this issue Apr 10, 2024
Closed
climategadgets added a commit that referenced this issue Apr 10, 2024
@climategadgets
Thermostat no longer pretends to be a ProcessController (#267, #314)
7d1d79d
climategadgets added a commit that referenced this issue Apr 19, 2024
@climategadgets
No longer blowing up on missing settings (#267)
ea6f10b
climategadgets added a commit that referenced this issue Apr 19, 2024
@climategadgets
No longer blowing up on missing economizer settings (#267)
40dad30
climategadgets added a commit that referenced this issue Jun 12, 2024
@climategadgets
Thermostat can now exist with a null setpoint (#267)
47c3f54
climategadgets added a commit that referenced this issue Jun 12, 2024
@climategadgets
ZoneSettings can now exist with null setpoint (#267)
63b3a79
climategadgets added a commit that referenced this issue Jun 22, 2024
@climategadgets
Merge branch 'gh267-no-setpoint' into dev (#267)
98e48a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement process control reactive-only Will be fixed in Reactive branches only setpoint usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@climategadgets