Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augment calendar schedule period definition with entities that came to existence since its creation #311

Closed
climategadgets opened this issue Apr 5, 2024 · 1 comment

Comments

@climategadgets
Copy link
Member

climategadgets commented Apr 5, 2024

Existing Behavior

Current schedule period definition is rather bland and basic, and it is parsed from a pretty simple string (schedule event summary).

At the same time, the economizer configuration can currently only be set at application startup time, with bits of its behavior even hidden in hardware configuration.

Desired Behavior

  • All configurable elements of the zone behavior can be defined by a calendar entry;
  • Period settings can be expressed in rich format (YAML being the primary candidate);
  • Backward compatibility with the previous period definition is preserved, a WARN level log message is issued suggesting a format change upon encountering such a definition, and the verbatim text of the new period definition entry provided.

Additional Considerations

It would be helpful to implement #269 in lockstep with this one - the old format event exported in a new format would be easier to deal with.

climategadgets added a commit that referenced this issue Apr 11, 2024
This commit contains the only curse word in the whole code base.
climategadgets added a commit that referenced this issue Apr 12, 2024
This commit contains the only curse word in the whole code base.
@climategadgets
Copy link
Member Author

Done as of rev. 64222de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant