Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnfoldRightView timer gets stuck and doesn't open die right view #59

Open
johandk89 opened this issue Apr 23, 2013 · 5 comments
Open

UnfoldRightView timer gets stuck and doesn't open die right view #59

johandk89 opened this issue Apr 23, 2013 · 5 comments

Comments

@johandk89
Copy link

When I toggle the right view with
[paperFold setPaperFoldState:PaperFoldStateRightUnfolded animated:YES];

the timer sometimes doesn't invalidate and calls the following method repeatedly blocking any unfolding animation
- (void)unfoldRightView:(NSTimer*)timer

@c-st
Copy link

c-st commented Apr 27, 2013

I think I am experiencing the same problem. Sometimes (randomly during testing) it's stuck and until the app is restarted. I haven't been able to track it down, though. I'm going to check if your issue is the same one I have.

Do you have a workaround already?

@johandk89
Copy link
Author

I commented out the onContentViewPannedVertically method in the PaperFoldView.m. I think what happens is the Paperfoldview registers a vertical pan and a horizontal pan and then it gets stuck. Hope this helps

@jhulst
Copy link

jhulst commented Jun 12, 2013

I had similar behavior and had to remove the assignment

self.paperFoldInitialPanDirection = PaperFoldInitialPanDirectionVertical; 

in onContentViewPanned.

This disabled all vertical panning but we don't have that functionality in our app anyways.

@lucaslt89
Copy link

I had a similar problem. The problem was that the timer was never being started, because i only added a right view.

I had to change this line:

if ((x < 0 && self.enableLeftFoldDragging) || (x > 0 && self.enableLeftFoldDragging))

for this one:

if ((x < 0 && self.enableLeftFoldDragging) || (x > 0 && self.enableRightFoldDragging))

@domingguss
Copy link

I came across this bug too and found an easy workaround for this one:

set the proper initialPanDirection BEFORE doing a setPaperFoldState. This way the timers properly walk through all the complex if-structures.

for example:

[_paperFoldView setPaperFoldInitialPanDirection:PaperFoldInitialPanDirectionHorizontal];
[_paperFoldView setPaperFoldState:PaperFoldStateLeftUnfolded];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants