Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingressClassName nested improperly in Refinery chart #422

Open
bixu opened this issue Jan 30, 2025 · 0 comments · May be fixed by #423
Open

ingressClassName nested improperly in Refinery chart #422

bixu opened this issue Jan 30, 2025 · 0 comments · May be fixed by #423

Comments

@bixu
Copy link
Contributor

bixu commented Jan 30, 2025 •
edited
Loading

Looking at this, I'm pretty sure what we meant to do was nest like:

ingress:
  ingressClassName:

but instead, we have ingressClassName as a top-level key.

The README actually specifies ingress.ingressClassName.
@bixu bixu changed the title ingressClassName nested improperly ingressClassName nested improperly in Refinery chart Jan 30, 2025
bixu added a commit to bixu/helm-charts that referenced this issue Jan 31, 2025
@bixu
Fix ingressClassName nesting in Refinery chart
c50927d 
Fixes honeycombio#422

Nest `ingressClassName` under `ingress` in the Refinery chart.

* Move `ingressClassName` under the `ingress` key in `charts/refinery/templates/ingress.yaml`
* Update the indentation to match the new structure
* Modify the condition to check for `ingress.ingressClassName` instead of `ingressClassName`

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/honeycombio/helm-charts/issues/422?shareId=XXXX-XXXX-XXXX-XXXX).
@bixu bixu linked a pull request Jan 31, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Normalize ingressClassName nesting in Refinery chart in accordance with README bixu/helm-charts
1 participant
@bixu