Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON unpacking doesn't seem to work in OTLP #90

Open
kentquirk opened this issue Jul 15, 2022 · 2 comments
Open

JSON unpacking doesn't seem to work in OTLP #90

kentquirk opened this issue Jul 15, 2022 · 2 comments
Labels
type: discussion Requests for comments, discussions about possible enhancements.

Comments

@kentquirk
Copy link
Contributor

kentquirk commented Jul 15, 2022

According to this conversation, this code should (maybe!) be creating maps, not strings.

Investigate JSON values in OTLP with .NET object types. Do we properly unpack the attributes in the object?

@kentquirk kentquirk added the type: bug Something isn't working label Jul 15, 2022
@kentquirk kentquirk changed the title Husky is converting OTLP key-values into strings, but they should be maps JSON unpacking doesn't seem to work in OTLP Jul 15, 2022
@JamieDanielson JamieDanielson added the type: discussion Requests for comments, discussions about possible enhancements. label Jul 20, 2022
@cartermp
Copy link
Member

@cartermp
Copy link
Member

For any non-Honeycomb viewers - the issue is that OTLP doesn't distinguish between a string and a json-encoded string. And it's incredibly expensive for us to scan every string for every attribute and try to parse out JSON. There are options we can pursue to enable JSON unpacking, but none are particularly amazing and do require some up-front work on behalf of end-users.

There's a discussion on enabling object types for attributes in OTLP that you can follow along here: open-telemetry/opentelemetry-specification#376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion Requests for comments, discussions about possible enhancements.
Projects
None yet
Development

No branches or pull requests

3 participants