Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "Annotation" rules as a way to dry-run individual rules #1495

Open
kentquirk opened this issue Feb 25, 2025 · 0 comments
Open

Allow "Annotation" rules as a way to dry-run individual rules #1495

kentquirk opened this issue Feb 25, 2025 · 0 comments
Labels
type: enhancement New feature or request

Comments

@kentquirk
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Refinery's Dry Run mode is useful during the early stages of an implementation, but it doesn't help once things are in production -- switching to Dry Mode again is likely to be very expensive and might overwhelm infrastructure.

Describe the solution you'd like

It would be nice to have the ability to test a new rule without affecting existing telmetry, so here's a proposal:

In addition to setting a sample rate and Drop: true as rule actions, we could support something like Annotate: true.

This would cause Refinery to add a new field meta.annotation to the root span (or to every span?). It would be set to the name of the specific refinery rule but would otherwise not change your existing rule behavior (it would be treated like a rule that didn't match).

Because it behaves like a rule that doesn't match, it would have to be placed before any rule that does match. This also means that some things that would have been annotated will be dropped before reaching Honeycomb.

It might also be interesting to allow a way to treat it like a rule that does match, so that it behaves more like dry run but at the rule level.

Describe alternatives you've considered

As far as I know, we've never considered an idea like this before now.

Additional context

Based on a customer request (internal slack).

@kentquirk kentquirk added the type: enhancement New feature or request label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant