From 31934f2fd472c8a93a14e6e212cc4cff90933382 Mon Sep 17 00:00:00 2001 From: Mohammed Date: Mon, 3 Jun 2024 16:07:49 +0300 Subject: [PATCH 1/3] feat(dependencies): show error if no package manager is installed Closes #45 --- src/hooks/dependencies.ts | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/hooks/dependencies.ts b/src/hooks/dependencies.ts index a9c572f..a9747a4 100644 --- a/src/hooks/dependencies.ts +++ b/src/hooks/dependencies.ts @@ -32,6 +32,21 @@ const registerInstallationHook = ( projectDependenciesHook.addHook(template, async ({ directoryPath }) => { let installDeps = false + const installedPackageManagerNames = await Promise.all( + knownPackageManagerNames.map(checkPackageManagerInstalled), + ).then((results) => + knownPackageManagerNames.filter((_, index) => results[index]), + ) + + // show error message if no package manager is installed + if (!installedPackageManagerNames.length) { + console.log( + chalk.red('×'), + 'No package manager found. Please install one any try again.', + ) + return exit(1) + } + if (typeof installArg === 'boolean') { installDeps = installArg } else { @@ -43,12 +58,6 @@ const registerInstallationHook = ( if (!installDeps) return - const installedPackageManagerNames = await Promise.all( - knownPackageManagerNames.map(checkPackageManagerInstalled), - ).then((results) => - knownPackageManagerNames.filter((_, index) => results[index]), - ) - let packageManager if (pmArg && installedPackageManagerNames.includes(pmArg)) { From 3d1d87480651908b9293d02134db53c70fa839f9 Mon Sep 17 00:00:00 2001 From: Mohammed Date: Mon, 3 Jun 2024 16:22:55 +0300 Subject: [PATCH 2/3] feat(dependencies): hide install option if no package manager detected Closes #45 --- src/hooks/dependencies.ts | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/hooks/dependencies.ts b/src/hooks/dependencies.ts index a9747a4..f6564ea 100644 --- a/src/hooks/dependencies.ts +++ b/src/hooks/dependencies.ts @@ -38,14 +38,8 @@ const registerInstallationHook = ( knownPackageManagerNames.filter((_, index) => results[index]), ) - // show error message if no package manager is installed - if (!installedPackageManagerNames.length) { - console.log( - chalk.red('×'), - 'No package manager found. Please install one any try again.', - ) - return exit(1) - } + // hide install dependencies option if no package manager is installed + if (installedPackageManagerNames.length) return if (typeof installArg === 'boolean') { installDeps = installArg From a7d7ab340ea462cb26543e32497a51350b9cf4c8 Mon Sep 17 00:00:00 2001 From: Mohammed Date: Mon, 3 Jun 2024 16:27:18 +0300 Subject: [PATCH 3/3] fix if condition --- src/hooks/dependencies.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hooks/dependencies.ts b/src/hooks/dependencies.ts index f6564ea..d2cd719 100644 --- a/src/hooks/dependencies.ts +++ b/src/hooks/dependencies.ts @@ -39,7 +39,7 @@ const registerInstallationHook = ( ) // hide install dependencies option if no package manager is installed - if (installedPackageManagerNames.length) return + if (!installedPackageManagerNames.length) return if (typeof installArg === 'boolean') { installDeps = installArg