Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login error improvement #36

Open
tleekkul opened this issue Aug 14, 2018 · 1 comment
Open

Login error improvement #36

tleekkul opened this issue Aug 14, 2018 · 1 comment

Comments

@tleekkul
Copy link
Contributor

Problems

  • User already has an account with Hotnow using username-password
  • User is trying to log in with another login type (Facebook or Google+)
  • Now Odin returns 500 internal server error so the user can't know what's wrong with his login.

Solutions

  • Return a better error message like "Invalid login type"
@KayEss
Copy link
Member

KayEss commented Aug 14, 2018

Why doesn't this automatically link the accounts? Or is this because the email address that comes back from FB or G+ is the same as one that is already in the system?

We need to be careful here if the email address we have against another a/c hasn't been activated yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KayEss @tleekkul