Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out split geometries with too few buildings #28

Closed
spwoodcock opened this issue Apr 15, 2024 · 2 comments · Fixed by #58
Closed

Filter out split geometries with too few buildings #28

spwoodcock opened this issue Apr 15, 2024 · 2 comments · Fixed by #58
Labels
bug Something isn't working effort:medium Likely a day or two priority:high Should be addressed as a priority

Comments

@spwoodcock
Copy link
Member

spwoodcock commented Apr 15, 2024

Describe the bug

  • The splitting algorithm may produce a random split geometry that contains no features (see the tiny blue polygon):

image

  • This shouldn't happen often, but is possible.
  • In order to avoid, we should filter out any final polygons that have areas smaller than a certain size, perhaps 10m2?

To Reproduce

  • AOI GeoJSON:
{"type":"FeatureCollection","features":[{"type":"Feature","properties":{},"geometry":{"coordinates":[[[85.29998911024427,27.714008043780694],[85.29998911024427,27.710892349952076],[85.30478315714117,27.710892349952076],[85.30478315714117,27.714008043780694],[85.29998911024427,27.714008043780694]]],"type":"Polygon"}}]}
  • Data extract attached as a .txt file to get around upload restrictions. Rename to .geojson:

kathmandu_extract.txt

  • Use the splitting algorithm set to 100 buildings average.

Expected behavior

  • Geometries like that are clearly an artifact that should be removed.
@spwoodcock
Copy link
Member Author

This should be fixed by #53

If we need an actual threshhold param, we can revisit this if needed.

@Sujanadh
Copy link
Contributor

Sujanadh commented Sep 23, 2024

Actually I think we don't care about area if it has sufficient features in it ( for example each task with around 40 features lets say if user wants to split by num_buildings=40), so we need to determine threshold based on the number of features per task maybe (-0.5x to 0.5x => 20-40-60 not less than 20 or not greater than 60)

@spwoodcock spwoodcock changed the title Filter out split geometries smaller than a specified area Filter out split geometries with too few buildings Sep 23, 2024
@spwoodcock spwoodcock reopened this Sep 23, 2024
@spwoodcock spwoodcock added priority:high Should be addressed as a priority effort:medium Likely a day or two labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort:medium Likely a day or two priority:high Should be addressed as a priority
Projects
Development

Successfully merging a pull request may close this issue.

2 participants