Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COD amount helper #862

Open
dt2patel opened this issue Nov 26, 2024 · 6 comments
Open

Add COD amount helper #862

dt2patel opened this issue Nov 26, 2024 · 6 comments
Assignees

Comments

@dt2patel
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

Add COD amount helper section so staff know easily how much COD to expect on their shipping label.

https://docs.google.com/document/d/1Z5VeHa66jqRUpWq-HjuEbn8mXkcZghSlMSDiyNQDskU/edit?tab=t.0#heading=h.t2o8w1t8effo

@dt2patel dt2patel moved this from 📋 Backlog to 🏗 In progress in Digital Experience Platform Nov 26, 2024
@dt2patel dt2patel moved this from 🏗 In progress to 📅 Planned in Digital Experience Platform Nov 26, 2024
@ymaheshwari1
Copy link
Contributor

ymaheshwari1 commented Dec 17, 2024

API endpoint details that can be used here:

endpoint: /api/service/getCODOrderRemainingTotal
Request payload:

{
    "orderId": "10110"
}

Response:

{
    "total": 5.00
}

Constraint: If Order does not have COD payment preference then it returns 0.

For more details: 86cwmx2rw

@ymaheshwari1 ymaheshwari1 moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Dec 24, 2024
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Jan 6, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Jan 7, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Jan 7, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Jan 7, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Jan 7, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Jan 7, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Jan 7, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Jan 9, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Jan 9, 2025
ymaheshwari1 added a commit that referenced this issue Jan 9, 2025
Implemented: support to display the remaining amount to be collected on the order based on COD payment and the related adjustments(#862)
@ymaheshwari1 ymaheshwari1 moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jan 9, 2025
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jan 9, 2025
@dt2patel
Copy link
Contributor Author

@AjinkyaM1 can you identify which OMS version is compatible with this feature? Add the relevant version number to this ticket for tracking

@AjinkyaM1
Copy link
Contributor

The backend changes have been pushed into the releases from version 5.18.0.

@ymaheshwari1
Copy link
Contributor

Closing as this is working as expected and already in production

@github-project-automation github-project-automation bot moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform Feb 6, 2025
@ymaheshwari1
Copy link
Contributor

Reopening, as we still need to test the flow where amount is not received.

@ymaheshwari1 ymaheshwari1 reopened this Feb 6, 2025
@github-project-automation github-project-automation bot moved this from ✅ Done to 📅 Planned in Digital Experience Platform Feb 6, 2025
@ymaheshwari1 ymaheshwari1 moved this from 📅 Planned to ⏸️ Dev complete in Digital Experience Platform Feb 6, 2025
@ymaheshwari1
Copy link
Contributor

ymaheshwari1 commented Feb 14, 2025

Discussed regarding the flow.

Need to remove the api support from the app and instead just check the COD payment preference on order and is it in NOT_RECEIVED status.

If an order is COD, but the payment status is other than NOT_RECEIVED, then COD UI and adjustments will not be displayed.

cc: @dt2patel Sir and @AjinkyaM1

@ymaheshwari1 ymaheshwari1 moved this from ⏸️ Dev complete to 📅 Planned in Digital Experience Platform Feb 14, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 17, 2025
…y in the app(hotwax#862)

Improved logic to display amount with fixed trauncated values
Added check to display the alert message on the basis of tracking code availability
@ymaheshwari1 ymaheshwari1 moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Feb 17, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 17, 2025
ymaheshwari1 added a commit that referenced this issue Feb 17, 2025
Removed: usage of COD remaining total api and added the logic directly in the app(#862)
@ymaheshwari1 ymaheshwari1 moved this from 🏗 In progress to ⏸️ Dev complete in Digital Experience Platform Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ⏸️ Dev complete
Development

No branches or pull requests

4 participants