Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove click event from shipped qty when 0 shipped #902

Open
dt2patel opened this issue Jan 20, 2025 · 3 comments
Open

Remove click event from shipped qty when 0 shipped #902

dt2patel opened this issue Jan 20, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dt2patel
Copy link
Contributor

<ion-chip outline @click="shippedHistory(item.productId)">

Here we should only have click event if shipped qty is greater than 1

@dt2patel dt2patel added the enhancement New feature or request label Jan 20, 2025
@dt2patel dt2patel moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Jan 20, 2025
@ravilodhi ravilodhi assigned R-Sourabh and unassigned ravilodhi Feb 7, 2025
@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Feb 7, 2025
R-Sourabh added a commit to R-Sourabh/fulfillment-pwa that referenced this issue Feb 7, 2025
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Feb 7, 2025
@ymaheshwari1
Copy link
Contributor

I think we should also add the same check on other pages as well, WDYT @dt2patel Sir?

@dt2patel
Copy link
Contributor Author

Sure makes sense. is there a fancy way to do this that does not require repeating same logic everywhere?

@ymaheshwari1
Copy link
Contributor

Sure makes sense. is there a fancy way to do this that does not require repeating same logic everywhere?

No, as the current implementation is written in such a way that will require adding this logic.

@R-Sourabh R-Sourabh moved this from 👀 In review to 🏗 In progress in Digital Experience Platform Feb 10, 2025
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 👀 In review
Development

No branches or pull requests

4 participants