Configurable showDoneButtonOnModals icon

[djfpaagman]

Right now when you enable showDoneButtonOnModals you get a "Done" (UIBarButtonItem.SystemItem.done) button on your modal. This could be confusing when having a form inside the modal, the user might assume the data also gets saved when they click "done".

I would prefer those modals to show "Close" (UIBarButtonItem.SystemItem.close) as I think that's more distinct and signalling that nothing is being saved.

Right now you can't configure what type of button is placed. I would also be happy with the default becoming close.

I can try to implement something but could use some direction on how to do so in Swift 😅

[djfpaagman]

I played around with it a bit and .close gives an icon:

So I think I prefer .cancel:

I've implemented it for now like so:

import HotwireNative
import UIKit

class CustomHotwireWebViewController: HotwireWebViewController {
    override func viewDidLoad() {
        super.viewDidLoad()
        
        addDoneButtonToModals()
    }
    private func addDoneButtonToModals() {
        if presentingViewController != nil {
            let action = UIAction { [unowned self] _ in
                dismiss(animated: true)
            }

            navigationItem.leftBarButtonItem = UIBarButtonItem(systemItem: .cancel, primaryAction: action)
        }
    }
}

and use CustomHotwireWebViewController instead of HotwireWebViewController in my SceneController! Make sure to disable Hotwire.config.showDoneButtonOnModals if you do this.

Maybe being able to customize it via a setting might still be nice :)

[joemasilotti]

Your approach, subclassing HotwireWebViewController, looks good to me. I don't see us exposing anything outside of the "Done" button via a configuration, there are just way too many options.