-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: (just a reminder) Stretchly: Unity not supported for DND detection, yet. #1528
Comments
So Gnome and Unity are the same or different? I am confused. For Gnome I am checking Is this different DE than you had in #1466 (comment)? |
ubuntu uses an adapted and extended version of gnome on wayland by default. unity used to be the default but has been abandoned for quite some time now. I do not understand why on my ubuntu 24.04 stretchly mentions unity not being supported. On what basis does stretchly concludes it is running on a unity desktop? |
My |
|
If you change this line stretchly/app/utils/dndManager.js Line 76 in 6dd2bc3
into
It should be working on gnome I guess |
same for mate and cinnamon, I'll test gnome |
When debugging I see that Both When I add unity to the gnome case, dnd works:
No need to add |
Thanks for checking it out! I will create some virtual machine with Gnome/Ubuntu and do some tests. Really strange the values are different... I guess I will need to find a way to get values that user sees when checking for them command line? |
do you autostart stretchly? can you try starting stretchly after de is loaded and check again what's in ENV/dtretchly? |
Also when starting after DE is loaded the values for XDG_CURRENT_DESKTOP are different in bash and from npm process. Found this electron/electron#40795 |
electron changes XDG_CURRENT_DESKTOP, see https://github.com/electron/electron/blob/ab2a4fd836d539194bc5cde5f0d665eddeb6a134/lib/browser/init.ts#L179 |
Nice catch! We should then replace all to ORIGINAL_XDG_CURRENT_DESKTOP |
@eduarddrenth do you wanna make a PR? You basically solved it :) |
fine |
Version
Known issues
Existing issues
Advanced Preferences
What operating system are you using?
Linux
Operating System Version
ubuntu 24.04.1
Reproduction steps
journalctl -f
Expected Behavior
Actual Behavior
see reporoduction steps
Relevant log output
No response
Preferences
No response
Additional information
after successfully fixing #1466 (thanks!) dnd does not work anymore on the default ubuntu-gnome desktop
Code of Conduct
The text was updated successfully, but these errors were encountered: