Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bootstrap npm starter #45

Merged
merged 44 commits into from
Jan 7, 2022
Merged

Use Bootstrap npm starter #45

merged 44 commits into from
Jan 7, 2022

Conversation

chrisma
Copy link
Member

@chrisma chrisma commented Aug 20, 2021

No description provided.

@chrisma chrisma marked this pull request as draft August 20, 2021 07:14
@LucPrestin LucPrestin linked an issue Aug 20, 2021 that may be closed by this pull request
chrisma and others added 27 commits August 20, 2021 10:22
@LucPrestin LucPrestin requested a review from SanJSp September 2, 2021 10:43
@LucPrestin LucPrestin changed the title Use Bootstrap npm starter (WIP) Use Bootstrap npm starter Sep 2, 2021
Copy link
Collaborator

@SanJSp SanJSp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of work! Thank you for that 🎈
But the rendering of the Home view is in some places buggy 🙅 I'd propose some changes so that it looks better 😊 Thank you for implementing them ☺️

assets/components/navigation-header.html Outdated Show resolved Hide resolved
assets/css/src/main.scss Outdated Show resolved Hide resolved
assets/js/home.js Outdated Show resolved Hide resolved
assets/components/components.js Outdated Show resolved Hide resolved
views/bootstraptest.html Outdated Show resolved Hide resolved
views/home.html Outdated Show resolved Hide resolved
@LucPrestin LucPrestin requested a review from SanJSp November 25, 2021 16:21
@github-pages github-pages bot temporarily deployed to github-pages November 27, 2021 14:11 Inactive
Copy link
Collaborator

@SanJSp SanJSp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the deployment and re-request then :)

@chrisma
Copy link
Member Author

chrisma commented Jan 7, 2022

Please fix the deployment and re-request then :)

Should work now :)

@chrisma chrisma merged commit 11c97f1 into main Jan 7, 2022
SanJSp added a commit that referenced this pull request Jan 24, 2022
@SanJSp
Copy link
Collaborator

SanJSp commented Jan 24, 2022

Has been reverted, because deployment is still not working

@SanJSp SanJSp mentioned this pull request Jan 26, 2022
chrisma added a commit that referenced this pull request Jan 29, 2022
* Use Bootstrap npm starter (#45)

* start with applying the bootstrap npm starter (WIP)

* Clean package.json, no purgeCSS

* use node modules instead of manually included scripts

* adapt view links to new paths

* Use compiled CSS files

* Add forgotten merge conflict

* remove starter CSS (now main.css)

* Fix merge

* gitignore CSS dist files

* Add bootstraptest page

* return to using a cdn instead of npm

* start adapting main page to the bootstrap example dashboard

* import whole bootstrap instead of single packages and use fontawesome icons

* remove files that should be ignored due to the .gitignore

* add prettier and eslint as npm scripts and run them

* move header in own file

* let header be appended via script instead of needing to add it via html too

* make sidebar navigation look like tab-pills

* add padding to header to not overlap with the main content; add active attribute to header depending on page

* adapt settings page to new visuals

* adapt team pages to new visuals

* adapt sprint page to new visuals

* make sidebar fixed to left

* load header via page script to avoid concurrency-issue; fix config not stored on settings page leave

* fix url parameter cut and thus not processable

* update readme

* apply prettier

* apply some pr-feedback

* fix header not getting attached when the view-script throws an error

* update some packages, remove unneeded icon-list scss file

* fix sidebar placement and run prettier

* update dependencies and run prettier

* fix minor issues and adapt index.html for deployment

* Update NPM packages

* Update NPM packages with breaking changes

* Update GH Actions workfow

* Some more NPM package updates

Co-authored-by: LucPrestin <[email protected]>

* Add .nojekyll file for GH Pages

* qucik fix for empty issue bodies

* removed debugger statements

* Add explanation to PR metrics

* Initial explanations for PR measures

* Add explanations for commit measures

* Add explanations to issue measures

* Revert "Use Bootstrap npm starter (#45)"

This reverts commit 11c97f1.

* removed individually comparable metric

* Update README.md

* Update README intro

* Updates to README

* Update NPM packages

* Update deploy action

Co-authored-by: LucPrestin <[email protected]>
Co-authored-by: Sandro Speh <[email protected]>
Co-authored-by: Sandro Sp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure Code for reuse and best practices
3 participants