From 45f68c78c1fdec5f6824dfe38cad202f9dbae8f9 Mon Sep 17 00:00:00 2001
From: Martin Schuhmacher <55735359+MartinSchuhmacher@users.noreply.github.com>
Date: Mon, 18 Nov 2024 18:28:18 +0100
Subject: [PATCH] BC-8181 - Implement New Room E2E Test in Cypress (#3451)

* adding test ids for rooms cypress tests

* fixing dataTestId
---
 src/modules/feature/room/RoomMembers/AddMembers.vue   | 8 +++++---
 src/modules/feature/room/RoomMembers/MembersTable.vue | 1 +
 src/modules/page/room/RoomCreate.page.vue             | 4 +++-
 src/modules/page/room/RoomDetails.page.vue            | 1 +
 src/modules/page/room/RoomEdit.page.vue               | 2 +-
 src/modules/page/room/RoomMembers.page.vue            | 5 +++--
 src/modules/page/room/Rooms.page.vue                  | 2 +-
 7 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/src/modules/feature/room/RoomMembers/AddMembers.vue b/src/modules/feature/room/RoomMembers/AddMembers.vue
index a3ee49bd3e..7a300dd8c0 100644
--- a/src/modules/feature/room/RoomMembers/AddMembers.vue
+++ b/src/modules/feature/room/RoomMembers/AddMembers.vue
@@ -8,7 +8,7 @@
 
 		<template v-slot:default>
 			<div class="ml-6 mr-6">
-				<div class="mt-3">
+				<div class="mt-3" data-testid="add-participant-school">
 					<v-autocomplete
 						ref="autoCompleteSchool"
 						v-model="selectedSchool"
@@ -22,7 +22,7 @@
 					/>
 				</div>
 
-				<div class="mt-4">
+				<div class="mt-4" data-testid="add-participant-role">
 					<v-autocomplete
 						ref="autoCompleteRole"
 						v-model="selectedRole"
@@ -37,7 +37,7 @@
 					/>
 				</div>
 
-				<div class="mt-4">
+				<div class="mt-4" data-testid="add-participant-name">
 					<v-autocomplete
 						ref="autoCompleteUsers"
 						v-model="selectedUsers"
@@ -64,6 +64,7 @@
 					class="ms-auto mr-2"
 					color="primary"
 					:text="t('common.actions.cancel')"
+					data-testid="add-participant-cancel-btn"
 					@click="onClose"
 				/>
 				<v-btn
@@ -72,6 +73,7 @@
 					color="primary"
 					variant="flat"
 					:text="t('common.actions.add')"
+					data-testid="add-participant-save-btn"
 					@click="onAddMembers"
 				/>
 			</div>
diff --git a/src/modules/feature/room/RoomMembers/MembersTable.vue b/src/modules/feature/room/RoomMembers/MembersTable.vue
index 3ef9a607c8..c2e287e19e 100644
--- a/src/modules/feature/room/RoomMembers/MembersTable.vue
+++ b/src/modules/feature/room/RoomMembers/MembersTable.vue
@@ -30,6 +30,7 @@
 			:no-data-text="t('common.nodata')"
 			:mobile="null"
 			mobile-breakpoint="sm"
+			data-testid="participants-table"
 			@update:current-items="onUpdateFilter"
 		>
 			<template #[`item.actions`]="{ item }">
diff --git a/src/modules/page/room/RoomCreate.page.vue b/src/modules/page/room/RoomCreate.page.vue
index 5c40596396..641a682c18 100644
--- a/src/modules/page/room/RoomCreate.page.vue
+++ b/src/modules/page/room/RoomCreate.page.vue
@@ -1,7 +1,9 @@
 <template>
 	<DefaultWireframe max-width="short" :breadcrumbs="breadcrumbs">
 		<template #header>
-			<h1 class="text-h3 mb-4">{{ $t("pages.rooms.fab.title") }}</h1>
+			<h1 class="text-h3 mb-4" data-testid="page-title">
+				{{ $t("pages.rooms.fab.title") }}
+			</h1>
 		</template>
 		<RoomForm :room="roomData" @save="onSave" @cancel="onCancel" />
 	</DefaultWireframe>
diff --git a/src/modules/page/room/RoomDetails.page.vue b/src/modules/page/room/RoomDetails.page.vue
index 9ce2019bdc..6cf03b0587 100644
--- a/src/modules/page/room/RoomDetails.page.vue
+++ b/src/modules/page/room/RoomDetails.page.vue
@@ -37,6 +37,7 @@
 							<VListItem
 								role="menuitem"
 								:to="`/rooms/${room.id}/members`"
+								data-testid="room-action-manage-participants"
 								:aria-label="t('pages.rooms.members.manage')"
 							>
 								<template #prepend>
diff --git a/src/modules/page/room/RoomEdit.page.vue b/src/modules/page/room/RoomEdit.page.vue
index 473ce2e028..28fd0cc8cb 100644
--- a/src/modules/page/room/RoomEdit.page.vue
+++ b/src/modules/page/room/RoomEdit.page.vue
@@ -1,7 +1,7 @@
 <template>
 	<DefaultWireframe max-width="short" :breadcrumbs="breadcrumbs">
 		<template #header>
-			<h1 class="text-h3 mb-4">
+			<h1 class="text-h3 mb-4" data-testid="page-title">
 				{{ $t("pages.roomDetails.ariaLabels.menu.action.edit") }}
 			</h1>
 		</template>
diff --git a/src/modules/page/room/RoomMembers.page.vue b/src/modules/page/room/RoomMembers.page.vue
index 3489407ba2..0a6dd825c0 100644
--- a/src/modules/page/room/RoomMembers.page.vue
+++ b/src/modules/page/room/RoomMembers.page.vue
@@ -6,7 +6,7 @@
 		@fab:clicked="onFabClick"
 	>
 		<template #header>
-			<h1 class="text-h3 mb-4">
+			<h1 class="text-h3 mb-4" data-testid="room-title">
 				{{ t("pages.rooms.members.manage") }}
 			</h1>
 		</template>
@@ -27,6 +27,7 @@
 			:width="xs ? 'auto' : 480"
 			persistent
 			max-width="480"
+			data-testid="dialog-add-participants"
 		>
 			<AddMembers
 				:memberList="potentialRoomMembers"
@@ -149,6 +150,6 @@ const fabAction = {
 	icon: mdiPlus,
 	title: t("pages.rooms.members.add"),
 	ariaLabel: t("pages.rooms.members.add"),
-	testId: "fab-add-members",
+	dataTestId: "fab-add-members",
 };
 </script>
diff --git a/src/modules/page/room/Rooms.page.vue b/src/modules/page/room/Rooms.page.vue
index 993684aede..b9b2d452a6 100644
--- a/src/modules/page/room/Rooms.page.vue
+++ b/src/modules/page/room/Rooms.page.vue
@@ -26,6 +26,6 @@ const fabAction = {
 	title: t("common.actions.create"),
 	to: "/rooms/new",
 	ariaLabel: t("pages.rooms.fab.title"),
-	testId: "fab-add-room",
+	dataTestId: "fab-add-room",
 };
 </script>