From 5fb40ea247d6395f27981e8dc157a39ce6213b20 Mon Sep 17 00:00:00 2001 From: Igor Richter Date: Fri, 15 Dec 2023 11:21:36 +0100 Subject: [PATCH] useTitle and test fix --- .../administration/ProvisioningOptionsPage.unit.ts | 4 ++++ .../administration/ProvisioningOptionsPage.vue | 11 +++++++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/components/administration/ProvisioningOptionsPage.unit.ts b/src/components/administration/ProvisioningOptionsPage.unit.ts index bf9943d747..0e59e67962 100644 --- a/src/components/administration/ProvisioningOptionsPage.unit.ts +++ b/src/components/administration/ProvisioningOptionsPage.unit.ts @@ -15,6 +15,10 @@ import * as routerComposables from "vue-router/composables"; jest.mock("@data-provisioning-options"); +jest.mock("@/utils/pageTitle", () => ({ + buildPageTitle: (pageTitle) => pageTitle ?? "", +})); + const $theme = { name: "instance name", }; diff --git a/src/components/administration/ProvisioningOptionsPage.vue b/src/components/administration/ProvisioningOptionsPage.vue index 595d4d821a..92fc04ea7b 100644 --- a/src/components/administration/ProvisioningOptionsPage.vue +++ b/src/components/administration/ProvisioningOptionsPage.vue @@ -93,7 +93,8 @@ import { import { useRouter } from "vue-router/composables"; import DefaultWireframe from "../templates/DefaultWireframe.vue"; import { Breadcrumb } from "../templates/default-wireframe.types"; -import { buildPageTitle } from "../../utils/pageTitle"; +import { buildPageTitle } from "@/utils/pageTitle"; +import { useTitle } from "@vueuse/core"; export default defineComponent({ name: "ProvisioningOptionsPage", @@ -112,6 +113,11 @@ export default defineComponent({ } = useProvisioningOptionsState(); const router = useRouter(); + const pageTitle = buildPageTitle( + t("components.administration.provisioningOptions.page.title") + ); + useTitle(pageTitle); + const schoolSettingsPage: Breadcrumb = { text: t("pages.administration.school.index.title"), to: "/administration/school-settings", @@ -133,9 +139,6 @@ export default defineComponent({ ); onMounted(async () => { - document.title = buildPageTitle( - t("components.administration.provisioningOptions.page.title") - ); await fetchProvisioningOptionsData(props.systemId); });