Skip to content

Commit

Permalink
BC-6035 - change check of npm version (#3367)
Browse files Browse the repository at this point in the history
  • Loading branch information
SevenWaysDP authored Dec 14, 2023
1 parent f9205d5 commit 0f711b8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 23 deletions.
20 changes: 4 additions & 16 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18

# extract branch name
- name: Extract branch name
if: github.event_name != 'pull_request'
shell: bash
run: echo "BRANCH_NAME=$(echo ${GITHUB_REF#refs/heads/})" >> $GITHUB_ENV
id: extract_branch

# extract branch name on pull request
- name: Print branch name
if: github.event_name == 'pull_request'
run: echo "BRANCH_NAME=$(echo ${GITHUB_HEAD_REF})" >> $GITHUB_ENV
node-version: '18'

- name: setup environment and execute mocha tests
run: bash scripts/unitTest.sh
run: npm ci && npm run build && npm run mocha
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"name": "schulcloud-client",
"private": true,
"scripts": {
"start": "node --unhandled-rejections=warn ./bin/www",
"watch": "nodemon --config nodemon.json",
Expand All @@ -15,7 +14,7 @@
},
"engines": {
"node": "18",
"npm": "9"
"npm": ">=9"
},
"lint-staged": {
"static/images/**/*.{png,jpeg,jpg,gif,svg}": [
Expand Down
5 changes: 0 additions & 5 deletions scripts/unitTest.sh

This file was deleted.

0 comments on commit 0f711b8

Please sign in to comment.