From 5c55860e97ddbca22d0cc390d2cf2a2c330725fe Mon Sep 17 00:00:00 2001
From: WojciechGrancow <116577704+WojciechGrancow@users.noreply.github.com>
Date: Thu, 15 Feb 2024 15:07:56 +0100
Subject: [PATCH] BC-6423 - fix submissions after creator deletion (#3403)

* fix submissions after deletion creatorId

* fix in homework

* remove consolelog

---------

Co-authored-by: Bartosz Nowicki <116367402+bn-pass@users.noreply.github.com>
---
 controllers/homework.js | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/controllers/homework.js b/controllers/homework.js
index f908914e21..60a9e47c58 100644
--- a/controllers/homework.js
+++ b/controllers/homework.js
@@ -655,7 +655,7 @@ router.get('/:assignmentId', (req, res, next) => {
 			if (!assignment.private && (isTeacher || assignment.publicSubmissions)) {
 				// Daten für Abgabenübersicht
 				const sortByStudentAttribute = (attr) => (a, b) => ((a.studentId[attr].toUpperCase() < b.studentId[attr].toUpperCase()) ? -1 : 1);
-				assignment.submissions = submissions.data.filter((submission) => submission.studentId)
+				assignment.submissions = submissions.data
 					.sort(sortByStudentAttribute('firstName'))
 					.sort(sortByStudentAttribute('lastName'))
 					.map((sub) => {
@@ -668,8 +668,7 @@ router.get('/:assignmentId', (req, res, next) => {
 					});
 				const studentSubmissions = students.map((student) => ({
 					student,
-					submission: assignment.submissions.filter((submission) => (submission.studentId._id == student._id)
-						|| (submission.teamMembers?.includes(student._id.toString())))[0],
+					submission: assignment.submissions.filter((submission) => (submission.teamMemberIds?.includes(student._id.toString())))[0],
 				}));
 
 				let studentsWithSubmission = [];