diff --git a/apps/server/src/modules/board/controller/dto/element/update-element-content.body.params.ts b/apps/server/src/modules/board/controller/dto/element/update-element-content.body.params.ts index 267135c687..1a662dabd3 100644 --- a/apps/server/src/modules/board/controller/dto/element/update-element-content.body.params.ts +++ b/apps/server/src/modules/board/controller/dto/element/update-element-content.body.params.ts @@ -140,10 +140,6 @@ export class VideoConferenceContentBody { @IsString() @ApiProperty() title!: string; - - @IsString() - @ApiProperty() - url!: string; } export class VideoConferenceElementContentBody extends ElementContentBody { diff --git a/apps/server/src/modules/board/controller/dto/element/video-conference-element.response.ts b/apps/server/src/modules/board/controller/dto/element/video-conference-element.response.ts index 2c4693009e..8eb6495e71 100644 --- a/apps/server/src/modules/board/controller/dto/element/video-conference-element.response.ts +++ b/apps/server/src/modules/board/controller/dto/element/video-conference-element.response.ts @@ -3,16 +3,12 @@ import { ContentElementType } from '../../../domain'; import { TimestampsResponse } from '../timestamps.response'; export class VideoConferenceElementContent { - constructor({ title, url }: VideoConferenceElementContent) { + constructor({ title }: VideoConferenceElementContent) { this.title = title; - this.url = url; } @ApiProperty() title: string; - - @ApiProperty() - url: string; } export class VideoConferenceElementResponse { diff --git a/apps/server/src/modules/board/controller/mapper/video-conference-element-response.mapper.ts b/apps/server/src/modules/board/controller/mapper/video-conference-element-response.mapper.ts index 235d25a951..5184fab13b 100644 --- a/apps/server/src/modules/board/controller/mapper/video-conference-element-response.mapper.ts +++ b/apps/server/src/modules/board/controller/mapper/video-conference-element-response.mapper.ts @@ -18,7 +18,7 @@ export class VideoConferenceElementResponseMapper implements BaseResponseMapper id: element.id, timestamps: new TimestampsResponse({ lastUpdatedAt: element.updatedAt, createdAt: element.createdAt }), type: ContentElementType.VIDEO_CONFERENCE, - content: new VideoConferenceElementContent({ title: element.title, url: element.url }), + content: new VideoConferenceElementContent({ title: element.title }), }); return result; diff --git a/apps/server/src/modules/board/domain/board-node.factory.ts b/apps/server/src/modules/board/domain/board-node.factory.ts index 5dfc236f43..54a640f610 100644 --- a/apps/server/src/modules/board/domain/board-node.factory.ts +++ b/apps/server/src/modules/board/domain/board-node.factory.ts @@ -91,7 +91,6 @@ export class BoardNodeFactory { element = new VideoConferenceElement({ ...this.getBaseProps(), title: '', - url: '', }); break; default: diff --git a/apps/server/src/modules/board/domain/types/board-node-props.ts b/apps/server/src/modules/board/domain/types/board-node-props.ts index 9cf43ced07..1c681a8413 100644 --- a/apps/server/src/modules/board/domain/types/board-node-props.ts +++ b/apps/server/src/modules/board/domain/types/board-node-props.ts @@ -69,7 +69,6 @@ export interface SubmissionItemProps extends BoardNodeProps { export interface VideoConferenceElementProps extends BoardNodeProps { title: string; - url: string; } export interface DeletedElementProps extends BoardNodeProps { diff --git a/apps/server/src/modules/board/domain/video-conference-element.do.spec.ts b/apps/server/src/modules/board/domain/video-conference-element.do.spec.ts index 0e93d7d00a..dfe7fb324e 100644 --- a/apps/server/src/modules/board/domain/video-conference-element.do.spec.ts +++ b/apps/server/src/modules/board/domain/video-conference-element.do.spec.ts @@ -17,7 +17,6 @@ describe('VideoConferenceElement', () => { beforeEach(() => { videoConferenceElement = new VideoConferenceElement({ ...boardNodeProps, - url: 'https://example.com', title: 'Example', }); }); @@ -30,15 +29,6 @@ describe('VideoConferenceElement', () => { expect(isVideoConferenceElement({})).toBe(false); }); - it('should return url', () => { - expect(videoConferenceElement.url).toBe('https://example.com'); - }); - - it('should set url', () => { - videoConferenceElement.url = 'https://newurl.com'; - expect(videoConferenceElement.url).toBe('https://newurl.com'); - }); - it('should return title', () => { expect(videoConferenceElement.title).toBe('Example'); }); diff --git a/apps/server/src/modules/board/domain/video-conference-element.do.ts b/apps/server/src/modules/board/domain/video-conference-element.do.ts index 56c4a2cd29..016057662f 100644 --- a/apps/server/src/modules/board/domain/video-conference-element.do.ts +++ b/apps/server/src/modules/board/domain/video-conference-element.do.ts @@ -2,14 +2,6 @@ import { BoardNode } from './board-node.do'; import type { VideoConferenceElementProps } from './types'; export class VideoConferenceElement extends BoardNode { - get url(): string { - return this.props.url ?? ''; - } - - set url(value: string) { - this.props.url = value; - } - get title(): string { return this.props.title ?? ''; } diff --git a/apps/server/src/modules/board/service/internal/content-element-update.service.spec.ts b/apps/server/src/modules/board/service/internal/content-element-update.service.spec.ts index c3e9894b3d..105d2726db 100644 --- a/apps/server/src/modules/board/service/internal/content-element-update.service.spec.ts +++ b/apps/server/src/modules/board/service/internal/content-element-update.service.spec.ts @@ -129,12 +129,10 @@ describe('ContentElementUpdateService', () => { it('should update VideoConferenceElement', async () => { const element = videoConferenceElementFactory.build(); const content = new VideoConferenceContentBody(); - content.url = 'http://example-vc.com/'; content.title = 'vc title'; await service.updateContent(element, content); - expect(element.url).toBe('http://example-vc.com/'); expect(element.title).toBe('vc title'); expect(repo.save).toHaveBeenCalledWith(element); }); diff --git a/apps/server/src/modules/board/service/internal/content-element-update.service.ts b/apps/server/src/modules/board/service/internal/content-element-update.service.ts index e826e66dde..4fe1d2c4ee 100644 --- a/apps/server/src/modules/board/service/internal/content-element-update.service.ts +++ b/apps/server/src/modules/board/service/internal/content-element-update.service.ts @@ -103,6 +103,5 @@ export class ContentElementUpdateService { updateVideoConferenceElement(element: VideoConferenceElement, content: VideoConferenceContentBody): void { element.title = content.title; - element.url = new URL(content.url).toString(); } } diff --git a/apps/server/src/modules/board/testing/entity/video-conference-element-entity.factory.ts b/apps/server/src/modules/board/testing/entity/video-conference-element-entity.factory.ts index 96c73978c7..f744a89fa8 100644 --- a/apps/server/src/modules/board/testing/entity/video-conference-element-entity.factory.ts +++ b/apps/server/src/modules/board/testing/entity/video-conference-element-entity.factory.ts @@ -12,7 +12,6 @@ export const videoConferenceElementEntityFactory = BoardNodeEntityFactory.define title: `video conference element #${sequence}`, position: 0, children: [], - url: `https://example.org/#${sequence}`, createdAt: new Date(), updatedAt: new Date(), type: BoardNodeType.VIDEO_CONFERENCE_ELEMENT, diff --git a/apps/server/src/modules/board/testing/video-conference-element.factory.ts b/apps/server/src/modules/board/testing/video-conference-element.factory.ts index 114c9a2c86..3a6e146ed3 100644 --- a/apps/server/src/modules/board/testing/video-conference-element.factory.ts +++ b/apps/server/src/modules/board/testing/video-conference-element.factory.ts @@ -14,7 +14,6 @@ export const videoConferenceElementFactory = BaseFactory.define { }) as RichTextElementResponse, createMockElement(faker.string.uuid(), ContentElementType.VIDEO_CONFERENCE, { - url: faker.internet.url(), title: faker.lorem.word(), }) as VideoConferenceElementResponse, diff --git a/apps/server/src/modules/common-cartridge/common-cartridge-client/card-client/mapper/card-response.mapper.ts b/apps/server/src/modules/common-cartridge/common-cartridge-client/card-client/mapper/card-response.mapper.ts index de2b0de2e4..cf8b228cb9 100644 --- a/apps/server/src/modules/common-cartridge/common-cartridge-client/card-client/mapper/card-response.mapper.ts +++ b/apps/server/src/modules/common-cartridge/common-cartridge-client/card-client/mapper/card-response.mapper.ts @@ -165,7 +165,7 @@ export class CardResponseMapper { new VideoConferenceElementResponseDto( element.id, ContentElementType.VIDEO_CONFERENCE, - new VideoConferenceElementContentDto(content.title, content.url), + new VideoConferenceElementContentDto(content.title), this.mapToTimestampDto(element.timestamps) ) );